Skip to content

perf: reschedule plus op #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iProzd merged 2 commits into from
Apr 1, 2025
Merged

perf: reschedule plus op #4688

iProzd merged 2 commits into from
Apr 1, 2025

Conversation

@caic99
Copy link
Member

@caic99 caic99 commented Mar 31, 2025 •
edited by coderabbitai bot
Loading

Similar changes of #4677

Brings +5% speed up compared with #4687

Summary by CodeRabbit

  • Refactor
    • Adjusted the order of operations in update calculations to enhance clarity while maintaining the same functional outcomes.

@caic99 caic99 requested review from Copilot and iProzd March 31, 2025 08:57
Copilot AI reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request rearranges the sequence of addition operations within the optim_angle_update and optim_edge_update functions to boost performance, achieving a +5% speedup over previous changes.

  • Updated the order of summing sub-tensor updates and bias in optim_angle_update.
  • Reordered addition operations in optim_edge_update to similarly optimize performance.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 31, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes involve reordering components in the optim_angle_update and optim_edge_update methods within the repflow_layer.py and repflows.py files. Specifically, the bias term is now added first in both methods, while the sub_angle_update term is moved to the end in optim_angle_update. The sequence of operations is modified, but the mathematical outcomes remain unchanged.

Changes

File(s) Change Summary
deepmd/pt/.../repflow_layer.py Reordered the addition order in optim_angle_update and optim_edge_update: bias is now first, and sub_angle_update is last in optim_angle_update. In optim_edge_update, bias is first, followed by sub_node_update, sub_edge_update, and sub_node_ext_update.
deepmd/dpmodel/.../repflows.py Similar reordering of terms in optim_angle_update and optim_edge_update: bias is first, and sub_angle_update is last in optim_angle_update. In optim_edge_update, bias is first, followed by sub_node_update, sub_edge_update, and sub_node_ext_update.

Possibly related PRs

Suggested reviewers

  • iProzd
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aad66f9 and 2dd7869.

📒 Files selected for processing (1)
  • deepmd/dpmodel/descriptor/repflows.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (30)
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Build wheels for cp311-win_amd64
  • GitHub Check: Build wheels for cp311-macosx_arm64
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Test Python (6, 3.12)
  • GitHub Check: Test Python (6, 3.9)
  • GitHub Check: Test Python (5, 3.12)
  • GitHub Check: Test Python (5, 3.9)
  • GitHub Check: Test Python (4, 3.12)
  • GitHub Check: Test Python (4, 3.9)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Test Python (3, 3.12)
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Test Python (3, 3.9)
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Test Python (2, 3.12)
  • GitHub Check: Build C++ (cuda, cuda)
  • GitHub Check: Test Python (2, 3.9)
  • GitHub Check: Build C++ (cpu, cpu)
  • GitHub Check: Analyze (python)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Test Python (1, 3.9)
  • GitHub Check: Analyze (c-cpp)
  • GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
  • GitHub Check: Test C++ (false)
  • GitHub Check: Test C++ (true)
🔇 Additional comments (2)
deepmd/dpmodel/descriptor/repflows.py (2)

836-842: Approve the performance optimization in optim_angle_update

The reordering of the terms in the addition operation places the scalar bias at the beginning and moves sub_angle_update to the end. While this doesn't change the mathematical outcome due to the commutative property of addition, it appears to provide performance benefits.

885-890: Approve the performance optimization in optim_edge_update

Similar to the change in optim_angle_update, this reordering places the scalar bias at the beginning of the addition sequence. This is a good optimization that doesn't affect the calculation result while improving performance.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (52f8ece) to head (2dd7869).
Report is 77 commits behind head on devel.

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel    #4688   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         692      692           
  Lines       66409    66408    -1     
  Branches     3538     3539    +1     
=======================================
  Hits        56320    56320           
+ Misses       8948     8947    -1     
  Partials     1141     1141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iProzd iProzd added this pull request to the merge queue Apr 1, 2025
Merged via the queue into deepmodeling:devel with commit 87426d5 Apr 1, 2025
60 checks passed
@caic99 caic99 deleted the reschedule-plus-op branch May 7, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@iProzd iProzd iProzd approved these changes

Assignees

No one assigned

Labels

Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caic99 @iProzd