Skip to content

Conversation

@HydrogenSulfate
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate commented Mar 25, 2025

update related document of CINN compiler

Summary by CodeRabbit

  • New Features

    • Introduced an experimental training command that offers an alternative mode for enhanced model performance.
  • Documentation

    • Updated training instructions to include new options for eager mode training as well as the experimental command.
    • Enhanced clarity around performance benefits to assist users in choosing the optimal training workflow.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2025

📝 Walkthrough

Walkthrough

This pull request updates the documentation in two areas. In deepmd/pd/utils/env.py, it refines the wording in the enable_prim function's comment to indicate that multiple operators are affected and emphasizes a performance improvement. It also exports a new variable, CINN. In addition, doc/train/training.md now includes new command examples for training using Paddle, featuring both the standard eager mode and an experimental CINN-enabled mode with a reference link for further details.

Changes

File Summary
deepmd/pd/utils/env.py Updated enable_prim comment to clarify that multiple operators are referenced and enhanced for better performance; added CINN to the exported list.
doc/train/training.md Added new training command examples for eager mode (dp --pd train input.json) and experimental CINN mode (CINN=1 dp --pd train input.json) with a note.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant Trainer

    User->>CLI: Enter training command (with/without "CINN=1")
    CLI->>Trainer: Initiate training process
    alt CINN enabled
        Trainer-->>Trainer: Execute training with CINN optimizations
    else Default
        Trainer-->>Trainer: Execute standard training routines
    end
    Trainer-->>CLI: Return training status
    CLI-->>User: Display training results
Loading

Possibly related PRs

Suggested labels

Docs, Python

Suggested reviewers

  • njzjz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e55cdf3 and 60b6801.

📒 Files selected for processing (2)
  • deepmd/pd/utils/env.py (2 hunks)
  • doc/train/training.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (28)
  • GitHub Check: Test Python (6, 3.12)
  • GitHub Check: Test Python (6, 3.9)
  • GitHub Check: Test Python (5, 3.12)
  • GitHub Check: Test Python (5, 3.9)
  • GitHub Check: Test Python (4, 3.12)
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Test Python (4, 3.9)
  • GitHub Check: Build wheels for cp311-win_amd64
  • GitHub Check: Test Python (3, 3.12)
  • GitHub Check: Test Python (3, 3.9)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Test Python (2, 3.12)
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Test Python (2, 3.9)
  • GitHub Check: Test C++ (false)
  • GitHub Check: Analyze (python)
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
  • GitHub Check: Test C++ (true)
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build C++ (cuda, cuda)
  • GitHub Check: Test Python (1, 3.9)
  • GitHub Check: Analyze (c-cpp)
  • GitHub Check: Build C++ (cpu, cpu)
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
🔇 Additional comments (3)
deepmd/pd/utils/env.py (2)

116-117: Documentation improvement in enable_prim docstring

The updated comment now clarifies that multiple operators are affected and emphasizes the performance benefit, which aligns with the purpose of this PR to improve CINN compiler documentation.


200-200: Export of CINN variable in __all__ list

Adding the CINN variable to the __all__ list makes it an exported entity from the module, which is appropriate since it's now referenced in the documentation and intended for user access.

doc/train/training.md (1)

32-38: Comprehensive documentation for Paddle training modes

The updated documentation clearly distinguishes between eager mode and CINN-enabled training, providing users with command examples for both options. The inclusion of a reference link for the CINN compiler is particularly helpful for users seeking more information about its performance benefits.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (e55cdf3) to head (60b6801).
Report is 79 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #4673      +/-   ##
==========================================
- Coverage   84.81%   84.81%   -0.01%     
==========================================
  Files         692      692              
  Lines       66360    66360              
  Branches     3539     3539              
==========================================
- Hits        56283    56282       -1     
  Misses       8937     8937              
- Partials     1140     1141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz njzjz added this pull request to the merge queue Mar 25, 2025
Merged via the queue into deepmodeling:devel with commit b97f023 Mar 25, 2025
60 checks passed
@HydrogenSulfate HydrogenSulfate deleted the update_document branch March 26, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants