CI: remove duration flag from pytest commands in workflows #4662

caic99 · 2025-03-20T09:38:11Z

Current CI command line arguments contains --durations=0 flag to output execution time of every test case. This will make it difficult to locate the real warning message.

Summary by CodeRabbit

Chores
- Updated internal test commands to modify how test durations are reported, simplifying the test output configuration.

Copilot

Pull Request Overview

This PR removes the "--durations=0" flag from pytest commands in the CI workflows to reduce excessive output that could hide warning messages.

Removed the "--durations=0" flag from the pytest command in the Python workflow.
Removed the "--durations=0" flag from the pytest command in the CUDA workflow.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
.github/workflows/test_python.yml	Removed "--durations=0" to improve warning message visibility.
.github/workflows/test_cuda.yml	Removed "--durations=0" to improve warning message visibility.

coderabbitai · 2025-03-20T09:41:20Z

📝 Walkthrough

Walkthrough

The pull request modifies two GitHub Actions workflow files used for testing. In both the CUDA and Python testing workflows, the --durations=0 option has been removed from the pytest command invocations. This change affects the reporting of test duration information during execution while leaving the overall test environment and exported entities unchanged.

Changes

File(s)	Change Summary
`.github/workflows/test_cuda.yml`, `.github/workflows/test_python.yml`	Removed the `--durations=0` flag from pytest commands in the CI workflows, modifying how test durations are reported.

Possibly related PRs

[r2] CI: fix Python workflow #4364: Involves removal of the --durations=0 option from pytest commands in the CUDA tests workflow.
ci: fix test-python test_durations and its caches #3820: Addresses removal of the --durations=0 flag in the Python test workflow file.
CI: set --clean-durations for pytest-split #4341: Contains similar modifications to pytest command options in GitHub Actions workflows.

Suggested reviewers

njzjz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between baaaa17 and fdcf589.

📒 Files selected for processing (2)

.github/workflows/test_cuda.yml (1 hunks)
.github/workflows/test_python.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (29)

GitHub Check: Test Python (6, 3.12)
GitHub Check: Test Python (6, 3.9)
GitHub Check: Test Python (5, 3.12)
GitHub Check: Test Python (5, 3.9)
GitHub Check: Build wheels for cp310-manylinux_aarch64
GitHub Check: Test Python (4, 3.12)
GitHub Check: Build wheels for cp311-win_amd64
GitHub Check: Test Python (4, 3.9)
GitHub Check: Build wheels for cp311-macosx_arm64
GitHub Check: Test Python (3, 3.12)
GitHub Check: Build C++ (clang, clang)
GitHub Check: Test Python (3, 3.9)
GitHub Check: Build wheels for cp311-macosx_x86_64
GitHub Check: Build C++ (rocm, rocm)
GitHub Check: Test Python (2, 3.12)
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Build C++ (cuda120, cuda)
GitHub Check: Test C++ (false)
GitHub Check: Test Python (2, 3.9)
GitHub Check: Analyze (python)
GitHub Check: Build C++ (cuda, cuda)
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Test C++ (true)
GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
GitHub Check: Test Python (1, 3.12)
GitHub Check: Build C++ (cpu, cpu)
GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
GitHub Check: Test Python (1, 3.9)
GitHub Check: Analyze (c-cpp)

🔇 Additional comments (3)

.github/workflows/test_cuda.yml (1)

60-62: Streamlined Pytest Command in CUDA Workflow

The removal of the --durations=0 flag from the pytest command (line 61) cleans up the test output as intended by the PR objectives. This change will help in reducing output clutter and allow developers to more easily locate warnings.

.github/workflows/test_python.yml (2)

56-59: Consistent Removal of Duration Flag in Main Test Command

The updated pytest command at line 58 no longer includes the --durations=0 flag. The remaining duration-related options (--store-durations --clean-durations --durations-path=.test_durations --splitting-algorithm least_duration) are still in place to handle test duration data as needed. This is consistent with the PR objectives, and the modifications look correct.

61-67: Clean Command for TF2 Eager Mode Tests

In the command at line 62, the removal of the --durations=0 flag aligns with the objective to simplify the output. The command now focuses solely on executing the tests for TF2 eager mode without extraneous duration details.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-03-20T10:28:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (baaaa17) to head (fdcf589).
Report is 78 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4662      +/-   ##
==========================================
- Coverage   84.80%   84.80%   -0.01%     
==========================================
  Files         692      692              
  Lines       66343    66343              
  Branches     3539     3539              
==========================================
- Hits        56264    56263       -1     
  Misses       8938     8938              
- Partials     1141     1142       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI: remove duration flag from pytest commands in workflows

fdcf589

caic99 requested review from Copilot and njzjz March 20, 2025 09:38

Copilot AI reviewed Mar 20, 2025

View reviewed changes

njzjz approved these changes Mar 20, 2025

View reviewed changes

njzjz added this pull request to the merge queue Mar 20, 2025

Merged via the queue into deepmodeling:devel with commit bb06e4f Mar 20, 2025
60 checks passed

caic99 deleted the ci-remove-durations branch March 21, 2025 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CI: remove duration flag from pytest commands in workflows #4662

CI: remove duration flag from pytest commands in workflows #4662

Uh oh!

caic99 commented Mar 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai bot commented Mar 20, 2025

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CI: remove duration flag from pytest commands in workflows #4662

CI: remove duration flag from pytest commands in workflows #4662

Uh oh!

Conversation

caic99 commented Mar 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

coderabbitai bot commented Mar 20, 2025

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

caic99 commented Mar 20, 2025 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Mar 20, 2025 •

edited

Loading