Skip to content

Conversation

@caic99
Copy link
Member

@caic99 caic99 commented Feb 11, 2025

fix #4595

Summary by CodeRabbit

  • Bug Fixes
    • Improved training summary display in distributed environments. Now, only the main process outputs the training summary, ensuring clearer and more concise logging without duplicate information.

@caic99 caic99 requested a review from njzjz February 11, 2025 04:43
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a conditional check on the execution of the SummaryPrinter() within the train function in both PD and PT entrypoints. The new variable LOCAL_RANK, imported from their respective utility modules, is used to ensure that the summary is printed only when LOCAL_RANK equals 0. Additionally, LOCAL_RANK is exported as a public variable in the corresponding utility modules.

Changes

File(s) Change Summary
deepmd/pd/entrypoints/main.py, deepmd/pt/entrypoints/main.py Modified the train function to call SummaryPrinter() only when LOCAL_RANK == 0.
deepmd/pd/utils/env, deepmd/pt/utils/env Added a new variable LOCAL_RANK as an exported/public entity.

Sequence Diagram(s)

sequenceDiagram
    participant T as Train Function
    participant E as Environment (LOCAL_RANK)
    participant S as SummaryPrinter

    T ->> E: Check LOCAL_RANK value
    alt LOCAL_RANK == 0
        T ->> S: Instantiate and execute SummaryPrinter()
    else LOCAL_RANK != 0
        T ->> T: Skip SummaryPrinter execution
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Print training summary only on rank 0 ([#4595])

Possibly related PRs

Suggested labels

Python

Suggested reviewers

  • njzjz
  • wanghan-iapcm

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea966e8 and 287edd0.

📒 Files selected for processing (2)
  • deepmd/pd/entrypoints/main.py (2 hunks)
  • deepmd/pt/entrypoints/main.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (16)
  • GitHub Check: Test Python (5, 3.12)
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Test Python (4, 3.12)
  • GitHub Check: Test Python (3, 3.12)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Test Python (3, 3.9)
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Test Python (2, 3.12)
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Test Python (2, 3.9)
  • GitHub Check: Build C++ (cuda, cuda)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test C++ (false)
  • GitHub Check: Build C++ (cpu, cpu)
  • GitHub Check: Test C++ (true)
  • GitHub Check: Test Python (1, 3.9)
🔇 Additional comments (2)
deepmd/pd/entrypoints/main.py (1)

236-237: LGTM! The summary printing is now correctly controlled by local rank.

The changes ensure that the summary is only printed when LOCAL_RANK == 0, which aligns with distributed training best practices.

deepmd/pt/entrypoints/main.py (1)

258-259: LGTM! The summary printing is now correctly controlled by local rank.

The changes ensure that the summary is only printed when LOCAL_RANK == 0, which aligns with distributed training best practices.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njzjz njzjz linked an issue Feb 11, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (65facbb) to head (287edd0).
Report is 65 commits behind head on devel.

Files with missing lines Patch % Lines
deepmd/pd/entrypoints/main.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #4597      +/-   ##
==========================================
- Coverage   84.57%   84.57%   -0.01%     
==========================================
  Files         680      680              
  Lines       64509    64509              
  Branches     3538     3539       +1     
==========================================
- Hits        54561    54560       -1     
+ Misses       8808     8807       -1     
- Partials     1140     1142       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 12, 2025
Merged via the queue into deepmodeling:devel with commit 176c746 Feb 12, 2025
60 checks passed
@caic99 caic99 deleted the fix-multiple-summary branch February 12, 2025 06:22
@njzjz njzjz modified the milestone: v3.0.2 Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] PT parallel training print summary on each node

3 participants