-
Notifications
You must be signed in to change notification settings - Fork 584
fix: print summary on local_rank=0 #4597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe pull request introduces a conditional check on the execution of the Changes
Sequence Diagram(s)sequenceDiagram
participant T as Train Function
participant E as Environment (LOCAL_RANK)
participant S as SummaryPrinter
T ->> E: Check LOCAL_RANK value
alt LOCAL_RANK == 0
T ->> S: Instantiate and execute SummaryPrinter()
else LOCAL_RANK != 0
T ->> T: Skip SummaryPrinter execution
end
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (16)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
njzjz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #4597 +/- ##
==========================================
- Coverage 84.57% 84.57% -0.01%
==========================================
Files 680 680
Lines 64509 64509
Branches 3538 3539 +1
==========================================
- Hits 54561 54560 -1
+ Misses 8808 8807 -1
- Partials 1140 1142 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix #4595
Summary by CodeRabbit