Skip to content

fix(2024Q1): fix lammps nlist sort with large sel #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iProzd merged 9 commits into from
Aug 1, 2024
Merged

fix(2024Q1): fix lammps nlist sort with large sel #3994

iProzd merged 9 commits into from
Aug 1, 2024

Conversation

@iProzd
Copy link
Collaborator

@iProzd iProzd commented Jul 18, 2024 •
edited
Loading

Copy from #3993 .

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (c09a1f7) to head (0e2e0f6).
Report is 10 commits behind head on 2024Q1.

Files with missing lines Patch % Lines
deepmd/dpmodel/atomic_model/linear_atomic_model.py 50.00% 1 Missing ⚠️
...eepmd/dpmodel/atomic_model/pairtab_atomic_model.py 50.00% 1 Missing ⚠️
deepmd/dpmodel/descriptor/hybrid.py 50.00% 1 Missing ⚠️
deepmd/dpmodel/descriptor/se_r.py 50.00% 1 Missing ⚠️
...epmd/pt/model/atomic_model/pairtab_atomic_model.py 50.00% 1 Missing ⚠️
deepmd/pt/model/descriptor/hybrid.py 75.00% 1 Missing ⚠️
deepmd/pt/model/descriptor/repformers.py 50.00% 1 Missing ⚠️
deepmd/pt/model/descriptor/se_r.py 50.00% 1 Missing ⚠️
deepmd/pt/model/model/frozen.py 50.00% 1 Missing ⚠️
deepmd/pt/model/model/spin_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           2024Q1    #3994      +/-   ##
==========================================
- Coverage   81.64%   81.64%   -0.01%     
==========================================
  Files         496      496              
  Lines       45795    45849      +54     
  Branches     2893     2893              
==========================================
+ Hits        37388    37432      +44     
- Misses       7528     7538      +10     
  Partials      879      879

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz
Copy link
Member

njzjz commented Jul 29, 2024

Do you plan to sync with #3993?

@iProzd
Copy link
Collaborator Author

iProzd commented Jul 29, 2024

Do you plan to sync with #3993?

yes, fixed in c52a0e0

@njzjz
Copy link
Member

njzjz commented Jul 30, 2024

If you want to fix the CI error in 2024Q1, apply #4009 and #4032

@iProzd iProzd merged commit 6d6fbb3 into deepmodeling:2024Q1 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njzjz njzjz njzjz approved these changes

@CaRoLZhangxy CaRoLZhangxy CaRoLZhangxy approved these changes

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees

No one assigned

Labels

LAMMPS Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iProzd @njzjz @CaRoLZhangxy @wanghan-iapcm