Fix: LinearModel Stat #3575
Merged
Fix: LinearModel Stat #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3575 +/- ##
==========================================
+ Coverage 81.80% 81.82% +0.01%
==========================================
Files 503 503
Lines 46456 46426 -30
Branches 2952 2952
==========================================
- Hits 38004 37987 -17
+ Misses 7559 7546 -13
Partials 893 893 ☔ View full report in Codecov by Sentry. |
njzjz
reviewed
Mar 21, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Collaborator
|
Should be revised when the #3593 is solved. |
Signed-off-by: Anyang Peng <137014849+anyangml@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Collaborator
wanghan-iapcm
left a comment
There was a problem hiding this comment.
test is required for the application of out_bias on the linearly combined model.
the other parts of the PR LGTM.
for more information, see https://pre-commit.ci
|
|
||
| def setUp(self): | ||
| TestCaseSingleFrameWithNlist.setUp(self) | ||
| nf, nloc, nnei = self.nlist.shape |
Check notice
Code scanning / CodeQL
Unused local variable
|
|
||
| def setUp(self): | ||
| TestCaseSingleFrameWithNlist.setUp(self) | ||
| nf, nloc, nnei = self.nlist.shape |
Check notice
Code scanning / CodeQL
Unused local variable
|
|
||
| def setUp(self): | ||
| TestCaseSingleFrameWithNlist.setUp(self) | ||
| nf, nloc, nnei = self.nlist.shape |
Check notice
Code scanning / CodeQL
Unused local variable
wanghan-iapcm
approved these changes
Apr 7, 2024
for more information, see https://pre-commit.ci
njzjz
approved these changes
Apr 7, 2024
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor stat related methods in LinearAtomicModel.
This should resolve #3585 #3586 #3528