Skip to content

clean up the init interface of pt.dataloader #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njzjz merged 7 commits into from
Mar 8, 2024
Merged

clean up the init interface of pt.dataloader #3434

njzjz merged 7 commits into from
Mar 8, 2024

Conversation

@CaRoLZhangxy
Copy link
Collaborator

@CaRoLZhangxy CaRoLZhangxy commented Mar 8, 2024

@github-actions github-actions bot added the Python label Mar 8, 2024
@codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.98%. Comparing base (09bd522) to head (277f538).

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel    #3434   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files         427      427           
  Lines       36753    36753           
  Branches     1621     1621           
=======================================
  Hits        28295    28295           
  Misses       7590     7590           
  Partials      868      868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz linked an issue Mar 8, 2024 that may be closed by this pull request
clean up the init interface of pt.dataloader #3427
Closed
njzjz
njzjz reviewed Mar 8, 2024
View reviewed changes
wanghan-iapcm
wanghan-iapcm reviewed Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as Jinzhe.

@njzjz njzjz enabled auto-merge March 8, 2024 08:55
@njzjz njzjz added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 8, 2024
@wanghan-iapcm wanghan-iapcm mentioned this pull request Mar 8, 2024
Closed
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@njzjz njzjz added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@njzjz njzjz added this pull request to the merge queue Mar 8, 2024
Merged via the queue into deepmodeling:devel with commit a9bcf41 Mar 8, 2024
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njzjz njzjz njzjz approved these changes

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees

No one assigned

Labels

Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clean up the init interface of pt.dataloader

3 participants

@CaRoLZhangxy @njzjz @wanghan-iapcm