Skip to content

Fix: ZBL state_dict duplicated keys #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anyangml merged 4 commits into from
Mar 12, 2024
Merged

Fix: ZBL state_dict duplicated keys #3432

anyangml merged 4 commits into from
Mar 12, 2024

Conversation

@anyangml
Copy link
Collaborator

@anyangml anyangml commented Mar 8, 2024 •
edited
Loading

No description provided.

@anyangml anyangml marked this pull request as draft March 8, 2024 03:00
@github-actions github-actions bot added the Python label Mar 8, 2024
@codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.39%. Comparing base (2ee8a3b) to head (4c902a7).

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3432      +/-   ##
==========================================
- Coverage   77.39%   77.39%   -0.01%     
==========================================
  Files         427      427              
  Lines       36755    36753       -2     
  Branches     1621     1621              
==========================================
- Hits        28446    28444       -2     
  Misses       7441     7441              
  Partials      868      868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml mentioned this pull request Mar 8, 2024
Merged
@anyangml anyangml self-assigned this Mar 8, 2024
@anyangml anyangml requested a review from njzjz March 11, 2024 03:23
@anyangml
Copy link
Collaborator Author

anyangml commented Mar 11, 2024 •
edited
Loading

This should fix ZBL freeze/test bug after #3443

@anyangml anyangml marked this pull request as ready for review March 11, 2024 04:26
@anyangml anyangml requested a review from iProzd March 11, 2024 10:21
@anyangml anyangml added this pull request to the merge queue Mar 12, 2024
Merged via the queue into deepmodeling:devel with commit bc35ac9 Mar 12, 2024
@anyangml anyangml deleted the fix/zbl_freeze branch March 12, 2024 02:12
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njzjz njzjz njzjz approved these changes

@iProzd iProzd Awaiting requested review from iProzd

Assignees

@anyangml anyangml

Labels

Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anyangml @njzjz