Merge change_energy_bias and fix finetune
#3378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
for more information, see https://pre-commit.ci
This reverts commit cdcfcb2.
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3378 +/- ##
==========================================
+ Coverage 76.69% 76.90% +0.21%
==========================================
Files 421 422 +1
Lines 35838 35825 -13
Branches 1620 1620
==========================================
+ Hits 27486 27552 +66
+ Misses 7484 7405 -79
Partials 868 868 ☔ View full report in Codecov by Sentry. |
njzjz
approved these changes
Mar 1, 2024
Collaborator
wanghan-iapcm
left a comment
There was a problem hiding this comment.
how do you validate that the change_energy_bias works as you want? How is it covered by UT?
wanghan-iapcm
approved these changes
Mar 3, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.