Skip to content

Conversation

@anyangml
Copy link
Collaborator

@anyangml anyangml commented Mar 1, 2024

No description provided.

@anyangml anyangml marked this pull request as draft March 1, 2024 05:55
@codecov
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (831610a) to head (c3ab69e).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3376   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files         420      420           
  Lines       35682    35682           
  Branches     1620     1620           
=======================================
  Hits        27323    27323           
  Misses       7491     7491           
  Partials      868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml requested a review from njzjz March 1, 2024 06:05
@anyangml anyangml requested review from iProzd and wanghan-iapcm March 1, 2024 06:05
@anyangml anyangml marked this pull request as ready for review March 1, 2024 06:06
@wanghan-iapcm wanghan-iapcm changed the title Chore: Update Developer Guide Doc: Update the developer guide for the v3 Mar 1, 2024
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The way of creating a new model in dp/pt looks very different from the old tf manner. shall we provide a separate doc for dp/pt model development?
  • we may introduce the idea of how to maintain models across platforms, then introduce the dp backend.
  • please tell the developers how to write UTs for cross-platform consistency.

@anyangml anyangml requested a review from wanghan-iapcm March 1, 2024 07:59
@anyangml anyangml requested a review from njzjz March 1, 2024 10:17
@wanghan-iapcm wanghan-iapcm enabled auto-merge March 1, 2024 14:34
@wanghan-iapcm wanghan-iapcm disabled auto-merge March 1, 2024 14:35
@anyangml anyangml added this pull request to the merge queue Mar 2, 2024
Merged via the queue into deepmodeling:devel with commit f4abe12 Mar 2, 2024
@anyangml anyangml deleted the chore/dev-doc branch March 2, 2024 05:27
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants