Feat: add dipole consistency test #3321

anyangml · 2024-02-22T03:43:41Z

This PR is to add cross framework consistency test on DipoleFittingNet.

Known Limitations:

There are some mismatched keys in the serialized model, only common keys are tested.

for more information, see https://pre-commit.ci

source/tests/consistent/fitting/test_dipole.py

+    @property
+    def skip_pt(self) -> bool:
+        (
+            resnet_dt,


source/tests/consistent/fitting/test_dipole.py

+    def skip_pt(self) -> bool:
+        (
+            resnet_dt,
+            precision,


source/tests/consistent/fitting/test_dipole.py

+        (
+            resnet_dt,
+            precision,
+            mixed_types,


source/tests/consistent/fitting/test_dipole.py

+
+    def build_tf(self, obj: Any, suffix: str) -> Tuple[list, dict]:
+        (
+            resnet_dt,


source/tests/consistent/fitting/test_dipole.py

+    def eval_pt(self, pt_obj: Any) -> Any:
+        (
+            resnet_dt,
+            precision,


source/tests/consistent/fitting/test_dipole.py

+        (
+            resnet_dt,
+            precision,
+            mixed_types,


source/tests/consistent/fitting/test_dipole.py

+
+    def eval_dp(self, dp_obj: Any) -> Any:
+        (
+            resnet_dt,


source/tests/consistent/fitting/test_dipole.py

+    def eval_dp(self, dp_obj: Any) -> Any:
+        (
+            resnet_dt,
+            precision,


source/tests/consistent/fitting/test_dipole.py

+        (
+            resnet_dt,
+            precision,
+            mixed_types,


codecov · 2024-02-22T03:51:06Z

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.31%. Comparing base (6345207) to head (9ac39b8).
Report is 1 commits behind head on devel.

Files	Patch %	Lines
deepmd/tf/model/multi.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #3321      +/-   ##
==========================================
+ Coverage   75.29%   75.31%   +0.01%     
==========================================
  Files         403      403              
  Lines       33910    33922      +12     
  Branches     1604     1604              
==========================================
+ Hits        25532    25547      +15     
+ Misses       7517     7514       -3     
  Partials      861      861

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for more information, see https://pre-commit.ci

source/tests/consistent/fitting/test_dipole.py

for more information, see https://pre-commit.ci

source/tests/consistent/fitting/test_dipole.py

+    def build_tf(self, obj: Any, suffix: str) -> Tuple[list, dict]:
+        (
+            resnet_dt,
+            precision,


source/tests/consistent/fitting/test_dipole.py

+        (
+            resnet_dt,
+            precision,
+            mixed_types,


for more information, see https://pre-commit.ci

deepmd/tf/fit/fitting.py

source/tests/consistent/common.py

deepmd/tf/fit/dipole.py

source/tests/tf/test_data_modifier_shuffle.py

deepmd/tf/fit/dipole.py

for more information, see https://pre-commit.ci

source/tests/tf/test_data_modifier.py

source/tests/tf/test_data_modifier_shuffle.py

for more information, see https://pre-commit.ci

deepmd/tf/model/model.py

for more information, see https://pre-commit.ci

Signed-off-by: Anyang Peng <137014849+anyangml@users.noreply.github.com>

feat: add dipole consistency test

e9dcf0f

anyangml self-assigned this Feb 22, 2024

github-actions bot added the Python label Feb 22, 2024

anyangml marked this pull request as draft February 22, 2024 03:43

[pre-commit.ci] auto fixes from pre-commit.com hooks

fb7447c

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems Feb 22, 2024

View reviewed changes

anyangml and others added 6 commits February 22, 2024 12:17

fix: add serialize, deserialize

2ad5db7

[pre-commit.ci] auto fixes from pre-commit.com hooks

3f38853

for more information, see https://pre-commit.ci

fix: UTs

5e78ce3

fix: UTs

e857afe

fix: UTs

cecdb8c

[pre-commit.ci] auto fixes from pre-commit.com hooks

501c534

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems Feb 22, 2024

View reviewed changes

source/tests/consistent/fitting/test_dipole.py Fixed Show fixed Hide fixed

anyangml and others added 3 commits February 22, 2024 14:23

fix: UTs

a3d4b00

fix: UTs

c5fd81b

[pre-commit.ci] auto fixes from pre-commit.com hooks

eee3048

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems Feb 22, 2024

View reviewed changes

anyangml and others added 10 commits February 22, 2024 15:07

fix: UTs

6da24c0

fix: UTs

e9d64cf

[pre-commit.ci] auto fixes from pre-commit.com hooks

8694af5

for more information, see https://pre-commit.ci

fix: UTs

58543e5

[pre-commit.ci] auto fixes from pre-commit.com hooks

0c0f28f

for more information, see https://pre-commit.ci

fix: UTs

36188a8

chore: move atom_ener to energyfitting

b453471

[pre-commit.ci] auto fixes from pre-commit.com hooks

13df1db

for more information, see https://pre-commit.ci

fix: UTs

6052f7e

[pre-commit.ci] auto fixes from pre-commit.com hooks

511e15e

for more information, see https://pre-commit.ci

anyangml commented Feb 22, 2024

View reviewed changes

deepmd/tf/fit/fitting.py Show resolved Hide resolved

anyangml commented Feb 22, 2024

View reviewed changes

source/tests/consistent/common.py Outdated Show resolved Hide resolved

njzjz requested changes Feb 22, 2024

View reviewed changes

deepmd/tf/fit/dipole.py Show resolved Hide resolved

source/tests/tf/test_data_modifier_shuffle.py Outdated Show resolved Hide resolved

deepmd/tf/fit/dipole.py Outdated Show resolved Hide resolved

anyangml and others added 2 commits February 23, 2024 01:37

fix: UTs

186a15e

[pre-commit.ci] auto fixes from pre-commit.com hooks

0a84f33

for more information, see https://pre-commit.ci

anyangml requested review from njzjz and wanghan-iapcm February 23, 2024 01:39

chore: refactor

abad3dd

njzjz reviewed Feb 23, 2024

View reviewed changes

source/tests/tf/test_data_modifier.py Outdated Show resolved Hide resolved

source/tests/tf/test_data_modifier_shuffle.py Outdated Show resolved Hide resolved

anyangml and others added 5 commits February 23, 2024 02:17

fix: se_r, se_t

3e0f3d8

[pre-commit.ci] auto fixes from pre-commit.com hooks

d2cbe46

for more information, see https://pre-commit.ci

chore: refactor

8bbaf25

[pre-commit.ci] auto fixes from pre-commit.com hooks

88d81a0

for more information, see https://pre-commit.ci

chore: typo

4c20c10

anyangml requested a review from njzjz February 23, 2024 02:31

njzjz reviewed Feb 23, 2024

View reviewed changes

deepmd/tf/model/model.py Outdated Show resolved Hide resolved

anyangml and others added 5 commits February 23, 2024 11:14

Merge branch 'devel' into devel

f538039

chore: refactor

3e2d1f9

chore: typo

9762912

[pre-commit.ci] auto fixes from pre-commit.com hooks

344910a

for more information, see https://pre-commit.ci

Merge branch 'devel' into devel

9fe7bbd

Signed-off-by: Anyang Peng <137014849+anyangml@users.noreply.github.com>

anyangml added the Test CUDA Trigger test CUDA workflow label Feb 23, 2024

github-actions bot removed the Test CUDA Trigger test CUDA workflow label Feb 23, 2024

anyangml requested a review from njzjz February 23, 2024 04:40

njzjz approved these changes Feb 23, 2024

View reviewed changes

wanghan-iapcm approved these changes Feb 23, 2024

View reviewed changes

wanghan-iapcm enabled auto-merge February 23, 2024 04:48

Merge branch 'devel' into devel

9ac39b8

wanghan-iapcm added this pull request to the merge queue Feb 23, 2024

Merged via the queue into deepmodeling:devel with commit 260ef21 Feb 23, 2024

njzjz mentioned this pull request Apr 2, 2024

[TYPO] #3635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat: add dipole consistency test #3321

Feat: add dipole consistency test #3321

Uh oh!

anyangml commented Feb 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

codecov bot commented Feb 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

Check notice

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feat: add dipole consistency test #3321

Feat: add dipole consistency test #3321

Uh oh!

Conversation

anyangml commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

codecov bot commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Check notice

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anyangml commented Feb 22, 2024 •

edited

Loading

codecov bot commented Feb 22, 2024 •

edited

Loading