Merge TF and PT CLI #3187
Merged
Merge TF and PT CLI #3187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, avoid import from deepmd.tf in deepmd.utils.argcheck. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
| return super().__new__(DeepPotTF) | ||
| elif backend == DPBackend.PyTorch: | ||
| from deepmd_pt.infer.deep_eval import DeepPot as DeepPotPT | ||
| from deepmd.pt.infer.deep_eval import DeepPot as DeepPotPT |
Check notice
Code scanning / CodeQL
Cyclic import
Comment on lines
+33
to
+35
| from deepmd.main import ( | ||
| parse_args, | ||
| ) |
Check notice
Code scanning / CodeQL
Cyclic import
| elif args.pt: | ||
| args.backend = "pytorch" | ||
| if args.backend == "tensorflow": | ||
| from deepmd.tf.entrypoints.main import main as deepmd_main |
Check notice
Code scanning / CodeQL
Cyclic import
| if args.backend == "tensorflow": | ||
| from deepmd.tf.entrypoints.main import main as deepmd_main | ||
| elif args.backend == "pytorch": | ||
| from deepmd.pt.entrypoints.main import main as deepmd_main |
Check notice
Code scanning / CodeQL
Cyclic import
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3187 +/- ##
==========================================
- Coverage 74.29% 74.25% -0.05%
==========================================
Files 343 343
Lines 31638 31653 +15
Branches 1592 1592
==========================================
- Hits 23506 23504 -2
- Misses 7207 7224 +17
Partials 925 925 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Jan 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just merge in form. Several options or subcommands are only supported by TensorFlow or PyTorch.
Also, avoid import from
deepmd.tfindeepmd.utils.argcheck.