Exclude type checking conditionals from coverage #644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8497f6 to
c9fa95a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 82.90% 82.92% +0.02%
==========================================
Files 195 195
Lines 18043 18037 -6
Branches 2409 2406 -3
==========================================
- Hits 14959 14958 -1
+ Misses 2261 2259 -2
+ Partials 823 820 -3 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Oh apparently upgrading to Python 3.10 already fixed the issue I didn't catch that sorry! It's now excluded as default: |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #624
I got the fix from https://coverage.readthedocs.io/en/7.10.1/excluding.html