-
Notifications
You must be signed in to change notification settings - Fork 133
Overhaul examples + quickstarts + datasets #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage ? 83.17%
=======================================
Files ? 200
Lines ? 19356
Branches ? 2626
=======================================
Hits ? 16099
Misses ? 2370
Partials ? 887 ☔ View full report in Codecov by Sentry. |
jscanvic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andrew! Just one last LaTeX annoyance
mh-nguyen712
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My latest comments, mostly minor typos.
Look really good! Thanks for the hard work Andrew!
jscanvic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
|
Please make sure the Colab quickstart notebook is updated correctly, @Andrewwango. I checked the last generated docs, and it seems they were not based on the latest version and the I’ll approve the PR once the tests have passed. |
tachella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my (I believe) final comments, I think the PR is looking great
tachella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes as follows:
Overhaul datasets
ImageFolderandTensorDatasetclassesOverhaul examples + quickstart
Trainercompatibility withDenoiser#593 )Minor fixes
load_exampledocs #669standart->standardphysics = GaussianNoise->physics = Denoising(GaussianNoise)Notes
auto_examples/basics/demo_quickstartintoindextoctreeotherwise the left sidebar doesn't show up in the quickstart example??Checks to be done before submitting your PR
python3 -m pytest deepinv/testsruns successfully.black .runs successfully.make htmlruns successfully (in thedocs/directory).Todo