feat: DH-20363: Pivot filter support #2602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2602 +/- ##
==========================================
+ Coverage 45.71% 46.19% +0.47%
==========================================
Files 771 771
Lines 43649 43677 +28
Branches 11046 11054 +8
==========================================
+ Hits 19954 20176 +222
+ Misses 23678 23484 -194
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgodinez-dh
reviewed
Jan 8, 2026
dgodinez-dh
approved these changes
Jan 9, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for filtering on pivot columns (e.g., ColumnBy) that use negative column indices, and makes filter input positioning extensible for plugins.
Added two new methods to
IrisGridMetricCalculator:getFilterInputCoordinates: Returns positioning for the filter input fieldgetAdvancedFilterButtonCoordinates: Returns positioning for the advanced filter buttonBoth methods return null for negative indices by default, allowing plugins to override for custom column types
Added
showAdvancedFilterButtonprop toFilterInputFieldto hide the advanced filter button for columns that don't support advanced filters.