mixclient: Dont append to slice with non-zero length.#3397
Merged
davecgh merged 1 commit intodecred:masterfrom Jun 28, 2024
Merged
mixclient: Dont append to slice with non-zero length.#3397davecgh merged 1 commit intodecred:masterfrom
davecgh merged 1 commit intodecred:masterfrom
Conversation
Immediately appending to a slice initialized with a non-zero length will lead to a slice which is twice as large as intended, with the initial half of the entries being left at their zero value. This is fixed by initializing the slice with **capacity** instead of length.
jrick
approved these changes
Jun 27, 2024
Member
jrick
left a comment
There was a problem hiding this comment.
funny bug, glad you caught this. it looks like this only affects the non-initial-blaming RS messages that other peers will send (which will include several zero hashes) but otherwise doesn't look like it is currently breaking anything.
matthawkins90
approved these changes
Jun 27, 2024
davecgh
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immediately appending to a slice initialized with a non-zero length will lead to a slice which is twice as large as intended, with the initial half of the entries being left at their zero value.
This is fixed by initializing the slice with capacity instead of length.