server: Prefer 3 min mix capable outbound peers.#3389
Merged
davecgh merged 1 commit intodecred:masterfrom Jun 18, 2024
Merged
Conversation
jrick
approved these changes
Jun 18, 2024
The current logic attempts to maintain at least one mix capable outbound peer to ensure better connectivity among the mix capable peers. It works as intended, however, only having a single mix capable peer means there will be delays if that peer goes offline until a replacement is found. A possible consequence is that any mix clients might potentially get interrupted if that peer goes offline and a replacement isn't found quickly enough. Attempting to maintain a minimum of three mix capable outbound peers will significantly reduce the likelihood of having periods without any mix capable peers. This updates the logic accordingly.
bbf9fd7 to
3099bb2
Compare
Member
Author
|
I shortened the debug message a bit per the edited PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic attempts to maintain at least one mix capable outbound peer to ensure better connectivity among the mix capable peers. It works as intended, however, only having a single mix capable peer means there will be delays if that peer goes offline until a replacement is found. A possible consequence is that any mix clients might potentially get interrupted if that peer goes offline and a replacement isn't found quickly enough.
Attempting to maintain a minimum of three mix capable outbound peers will significantly reduce the likelihood of having periods without any mix capable peers.
This updates the logic accordingly.