mixpool: Only ban full nodes for bad UTXO sigs#3345
Merged
davecgh merged 1 commit intodecred:masterfrom Jun 4, 2024
Merged
Conversation
ae30987 to
2fdeb98
Compare
davecgh
reviewed
Jun 4, 2024
Member
davecgh
left a comment
There was a problem hiding this comment.
Looks good. Will approve and merge after squash.
If an invalid UTXO signature in a pair request message is received from any node besides a full node, reject the message but do not ban for the error. However, full nodes are required to check this before relaying. Ban any self-reporting full node that still sends these invalid messages Because the banning logic is currently isolated to the mixpool package and mixpool is unaware of the capabilities of the peer that provided the message, give IsBannable an additional service flags argument. This changes the semantics of the bannable errors to only be bannable when all of the required service flags are described.
davecgh
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an invalid UTXO signature in a pair request message is received from any
node besides a full node, reject the message but do not ban for the error.
However, full nodes are required to check this before relaying. Ban any
self-reporting full node that still sends these invalid messages.
Because the banning logic is currently isolated to the mixpool package and
mixpool is unaware of the capabilities of the peer that provided the message,
give IsBannable an additional service flags argument. This changes the
semantics of the bannable errors to only be bannable when all of the required
service flags are described.