server: Remove dup min protocol version check.#3335
Merged
davecgh merged 1 commit intodecred:masterfrom May 29, 2024
Merged
Conversation
Previously, outbound peers were required to have a newer minimum protocol version than inbound peers, so two different checks were needed to differentiate. However, now that both inbound and outbound peers are required to have the same minimum version, there is no longer any need to have both checks for the same thing. Thus, this removes the additional check that is no longer needed.
dajohi
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, outbound peers were required to have a newer minimum protocol version than inbound peers, so two different checks were needed to differentiate.
However, now that both inbound and outbound peers are required to have the same minimum version, there is no longer any need to have both checks for the same thing.
Thus, this removes the additional check that is no longer needed.