multi: replace GetScriptClass consensus calls.#2031
Merged
davecgh merged 1 commit intodecred:masterfrom Feb 8, 2020
Merged
Conversation
beb53e3 to
5556a68
Compare
davecgh
requested changes
Jan 10, 2020
Member
davecgh
left a comment
There was a problem hiding this comment.
I haven't reviewed the scripttype.go file for correctness yet, but I wanted to get an initial review out since it will require some changes.
In addition, I see no tests for the new funcs and the documentation (doc.go and README.md) for the standalone package haven't been updated.
Overall, I think this is going in the right direction.
5556a68 to
6e9be3c
Compare
6e9be3c to
d612316
Compare
davecgh
reviewed
Jan 31, 2020
davecgh
requested changes
Jan 31, 2020
This removes GetScriptClass consensus calls in favour of using script type identification functions defined in the blockchain package.
d612316 to
82dd899
Compare
davecgh
approved these changes
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
GetScriptClassconsensus calls in favour of using script type identificationfunctions defined in the blockchain package.
Resolves #1626.