Comparing changes
Open a pull request
- 14 commits
- 17 files changed
- 3 contributors
Commits on Aug 28, 2024
-
-
[release-v2.0] mixclient: Dont append to slice with non-zero length.
Immediately appending to a slice initialized with a non-zero length will lead to a slice which is twice as large as intended, with the initial half of the entries being left at their zero value. This is fixed by initializing the slice with **capacity** instead of length.
-
-
-
-
[release-v2.0] mixclient: Remove submit queue channel
The submit queue channel was not actually increasing any performance. (*peer).submit() would synchronously wait for all error results, and the call to (*Wallet).SubmitMixMessage was already synchronized by the mixpool mutex. Furthermore, this also fixes a deadlock that was observed after a mixing wallet with the RPC syncer mode reconnected to a restarted dcrd. Pair request messages were being submitted onto the channel with the client mutex held in (*Client).Dicemix. However, handleSubmitQueue had already exited and the client had not yet been restarted after dcrd reconnect, and was unable to be started due to the locked mutex.
-
[release-v2.0] mixclient: Do not submit PRs holding client mutex
The client mutex was being held during the initial publishing of pair request messages to prevent a situation where a submit errored but the peer was still associated with the client, or the message was submitted to mixpool and sent to other peers but our local peer had not yet been associated to the client at the time an epoch tick occurred. This should not be a situation we will encounter anymore, since the PR submissions are spaced out intentionally to avoid sending them close to the epoch.
-
-
[release-v2.0] mixclient: Use newest (fewest-PR) KEs to form alt sess…
…ions The alternate session forming only incrementally removes PRs from the currently considered PR set. Even if a PR by a responsive peer is known, if it was removed due to not passing the majority checks earlier, it will never be used by our peers during this epoch. With that in mind, we should only use the most recent KEs with the lowest referenced PR counts when trying to form an alternate session, as the additional PRs from earlier KEs will never be reconsidered by that KE's identity.
-
[release-v2.0] main: Use backported mixing updates.
This updates the 2.0 release branch to use the latest version of the mixing module which includes updates to improve session formation and increase performance. In particular, the following updated module version is used: - github.com/decred/dcrd/mixing@v0.4.1
-
[release-v2.0] main,certgen: Punycode non-ASCII hostnames
When a certificate is autogenerated by dcrd or with gencerts, errors would occur if any hostname contained non-ASCII characters. While X509 certificates do support UTF8 strings, Go does not yet support creating these. Instead, as a workaround and to keep certificate generation working to avoid errors at dcrd startup, convert hostnames with non-ASCII Unicode characters to their IDNA form, which uses Punycode to ASCII-encode the problematic Unicode characters.
-
[release-v2.0] main: Use backported certgen updates.
This updates the 2.0 release branch to use the latest version of the certgen module which includes updates to support Internationalized Domain Names (IDNs) via Punycode. In particular, the following updated module version is used: - github.com/decred/dcrd/certgen@v1.2.0
-
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff release-v2.0.3...release-v2.0.4