Skip to content

Fix access or manage initiative components#9458

Closed
agustibr wants to merge 2 commits intodevelopfrom
fix/initiative_admin_manage_components
Closed

Fix access or manage initiative components#9458
agustibr wants to merge 2 commits intodevelopfrom
fix/initiative_admin_manage_components

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Jun 22, 2022

🎩 What? Why?

This PR fixes a bug where admins can't manage components that are in the initiative space, also participants can´t access the initiative components public views.
This is the error:

Could not render layout: undefined method `context' for #<Decidim::ResourceManifest:0x000055b6dfdb6b40  ...

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

  • Log in as an admin
  • go to manage an Intitative
  • go to manage the initiative's component
  • It's possible to manage the component!

📷 Screenshots

Before:

TBD

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@agustibr agustibr added module: initiatives type: fix PRs that implement a fix for a bug labels Jun 22, 2022
@agustibr agustibr self-assigned this Jun 22, 2022
@agustibr agustibr changed the title Fix admin can manage initiative components Fix access or manage initiative components Jun 22, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor

#9633 will fix this issue with the related bug report and it's ready for review already. I took a slightly different approach solving it but should work just as well.

Closing this PR to clear it off from the backlog.

@ahukkanen ahukkanen closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: initiatives type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants