Skip to content

Add hyperlink to title in admin dashboard meetings listing#9400

Closed
roxanaopr wants to merge 1 commit intodecidim:developfrom
i-need-another-coffee:feature/add-hyperlink-to-meeting-title
Closed

Add hyperlink to title in admin dashboard meetings listing#9400
roxanaopr wants to merge 1 commit intodecidim:developfrom
i-need-another-coffee:feature/add-hyperlink-to-meeting-title

Conversation

@roxanaopr
Copy link
Copy Markdown
Contributor

🎩 What? Why?

At the moment, in admin dashboard - pick a topic - proposal or meeting component, it can be noticed that the tile of the proposals are hyperlinked and take the user to the proposal page with details but the meetings are not hyperlinked within the list.
The expected behavior is to have a link added to the meeting's title that will be a redirect tot the public page (like "Preview" action).

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@roxanaopr roxanaopr changed the title Add hyperlink to title in admin dashboard meetings listing #9393 Add hyperlink to title in admin dashboard meetings listing Jun 8, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor

This is sure an inconsistency with the current admin UI.

However I think the whole admin experience is really confusing when we link the title items of e.g. proposals to the participant view. This is really confusing experience and causes many gray hairs for Decidim admins every day. I am even confused about this every time I use the admin panel and I've been using Decidim for a while (so I should be used to it already if it was intuitive behavior?).

Since we can open the meeting preview using the "eye" icon in the meetings component, I think this is much better and what the user would normally expect to happen.

So instead of breaking the meetings component with this "feature", I would suggest the following instead:

  • Remove the participant view link from the proposals title
  • Add an eye icon to the proposals admin listing which opens the participant view

Same thing also for the components listing at /admin/participatory_processes/foobar/components:

  • Remove the participant view link from the component title
  • Add an eye icon to the components admin listing which opens the participant view

What do you think about this @andreslucena ?

@ahukkanen ahukkanen requested a review from andreslucena June 8, 2022 15:54
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Jun 9, 2022

What do you think about this @andreslucena ?

I agree that my last solution is not optimal. After talking about this with @carolromero, we agreed with what you say, as it's simpler:

  1. Drop the links from every title in these tables of the admin's manage pages. This means we'll also drop it from the Spaces tables too.
  2. Add the "Eye" icon in every of these tables where's missing.

@roxanaopr could you implement that please? If it's too much work, let me know, and I can tackle that.

@roxanaopr
Copy link
Copy Markdown
Contributor Author

@andreslucena I will implement those changes 😄

@roxanaopr
Copy link
Copy Markdown
Contributor Author

roxanaopr commented Jun 14, 2022

@ahukkanen
Copy link
Copy Markdown
Contributor

@roxanaopr @andreslucena

I would NOT change the accountability component because currently the title link gets you to manage the sub-resources for that result which is very much needed behavior. Otherwise I'm not sure if there's any path to that view?

I also slightly disagree with @carolromero (as pointed out above by @andreslucena) that we would drop the title links completely from the admin panel. I would definitely

  1. Keep the title links where they keep you within the admin panel, IMO these work fine as-is
  2. Change the title link to point to that resource at the admin panel where it currently takes you to the participant view

That's how I would do the change but I also am not the one pulling the cords here, so you should prioritize @carolromero's and @andreslucena's opinion over mine (in that order).

@roxanaopr
Copy link
Copy Markdown
Contributor Author

I would NOT change the accountability component because currently the title link gets you to manage the sub-resources for that result which is very much needed behavior. Otherwise I'm not sure if there's any path to that view?

@ahukkanen Title link from accountability title has the same value as the action "Result" (+), so the behavior will remain there, but through actions.
accountability_link

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen Title link from accountability title has the same value as the action "Result" (+), so the behavior will remain there, but through actions. accountability_link

Ah thanks. Good to know!

@andreslucena
Copy link
Copy Markdown
Member

@andreslucena can you please confirm that this items are including all the changes required?

@roxanaopr I found a couple more:

Components:

Change the title link to point to that resource at the admin panel where it currently takes you to the participant view

The problem with that is that then in some cases we wouldn't have links (such as on user generated resources, like Meetings or Debates). For instance:

image

I've added a link in one of these titles, but you would only notice that on hover. This is a problem for discoverability and also on devices that don't have a hover (like mobiles and tablets).

@andreslucena
Copy link
Copy Markdown
Member

Also, just to say it once more, this could/will probably change with the Redesign, so of course feel free to say no to this change if it's too much work @roxanaopr!

@roxanaopr
Copy link
Copy Markdown
Contributor Author

roxanaopr commented Jun 15, 2022

@andreslucena So we will go with this option, right?:

  1. Drop the links from every title in these tables of the admin's manage pages. This means we'll also drop it from the Spaces tables too.
  2. Add the "Eye" icon in every of these tables where's missing.

I saw that on issue page is mentioned also "edit" action for those that cannot have it. It is corect?

@roxanaopr
Copy link
Copy Markdown
Contributor Author

@andreslucena
Copy link
Copy Markdown
Member

@andreslucena So we will go with this option, right?:

Yes! I'd also add to be extra careful that we have the "Pencil" icon (Edit page) everywhere, too.

@andreslucena
Copy link
Copy Markdown
Member

@roxanaopr I see that there were a comment that I've left unateneded, sorry.

@andreslucena Also this link seems to be invalid: nightly.decidim.org/admin/participatory_processes/confuse-figure/attachment_collections?locale=es

Nightly had a problem, now it's back. Take into account that as the DB is regenerated, the URLs will change (so you'll need to find a valid process slug on this case).

@roxanaopr
Copy link
Copy Markdown
Contributor Author

roxanaopr commented Jun 21, 2022

@andreslucena on Participatory processes listing page (https://nightly.decidim.org/admin/participatory_processes) there are multiple links applied on the title of the process, based on permissions:
Screenshot from 2022-06-21 11-57-53
On that page, we have the following actions: Export all, Duplicate, Configure, Preview
Screenshot from 2022-06-21 12-00-46
What behaviour should we have for this listing page?

Same thing for assemblies
Screenshot from 2022-06-23 18-50-13

@roxanaopr
Copy link
Copy Markdown
Contributor Author

And another question for @andreslucena and @ahukkanen: Should I create a new branch for the changes and a new PR or we keep this one because we have the conversation?

@andreslucena
Copy link
Copy Markdown
Member

What behaviour should we have for this listing page?

@roxanaopr we should have the same behavior always on all the tables: without links. It'd be the final else on your screenshot, eg:

<%= translated_attribute(assembly.title) %>

Should I create a new branch for the changes and a new PR or we keep this one because we have the conversation?

I personally prefer to start a new PR linking to this one and the original issue, so the discussion is cleaner, but whatever is more comfortable for you.

@andreslucena
Copy link
Copy Markdown
Member

Closing in favor of #9496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants