(deprecated) Alert from frontend errors in critical paths#9356
Closed
txus wants to merge 3 commits intodecidim:developfrom
Closed
(deprecated) Alert from frontend errors in critical paths#9356txus wants to merge 3 commits intodecidim:developfrom
txus wants to merge 3 commits intodecidim:developfrom
Conversation
ahukkanen
requested changes
May 24, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
There's some accessibility issues with the browsers default alert/confirm/unload dialogs, so could we use custom modals instead for these alerts?
Contributor
Author
|
Fixed, now we shoud the failure page that already existed there. |
Member
|
@microstudi can you check this PR and fix it please? Thanks |
Contributor
|
I'll take a look this week |
Contributor
|
@txus could you help us with an update here ? cc @oriolgual , @mrcasals |
Member
|
I'm closing this one in favor of #10937 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise they just show up in the console and the user never knows.