Skip to content

Enable lint related Rubocop rules#9231

Merged
ahukkanen merged 18 commits intodecidim:developfrom
i-need-another-coffee:ale-fix-lint-rubocop
May 6, 2022
Merged

Enable lint related Rubocop rules#9231
ahukkanen merged 18 commits intodecidim:developfrom
i-need-another-coffee:ale-fix-lint-rubocop

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented May 4, 2022

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu added dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels May 4, 2022
@alecslupu alecslupu force-pushed the ale-fix-lint-rubocop branch from 634f993 to f1b6fe2 Compare May 5, 2022 06:48
@alecslupu alecslupu force-pushed the ale-fix-lint-rubocop branch from f1b6fe2 to b768e5b Compare May 5, 2022 08:21
@alecslupu alecslupu changed the title Ale fix lint rubocop Fix lint related rubocop violations May 5, 2022
@alecslupu alecslupu marked this pull request as ready for review May 5, 2022 08:58
@alecslupu alecslupu requested a review from ahukkanen May 5, 2022 08:58
@ahukkanen ahukkanen changed the title Fix lint related rubocop violations Enable lint related Rubocop rules May 5, 2022
ahukkanen
ahukkanen requested changes May 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get rid of some of the disable blocks + one question regarding disabling the bin folder completely. The less disable blocks we have, the better.

Comment thread .rubocop_ruby.yml Outdated
Comment thread decidim-core/app/queries/decidim/public_activities.rb Outdated
Comment thread decidim-core/spec/lib/reminder_registry_spec.rb Outdated
Comment thread decidim-core/spec/lib/participatory_space_manifest_spec.rb Outdated
Comment thread decidim-core/spec/lib/component_manifest_spec.rb Outdated
Comment thread decidim-core/spec/lib/component_manifest_spec.rb Outdated
Comment thread decidim-core/spec/lib/component_manifest_spec.rb Outdated
@ahukkanen ahukkanen merged commit 721fb18 into decidim:develop May 6, 2022
@alecslupu alecslupu deleted the ale-fix-lint-rubocop branch May 6, 2022 21:02
@andreslucena andreslucena mentioned this pull request May 19, 2022
Merged
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alecslupu @ahukkanen