Add UUID to export calendar URL#9115
Conversation
|
|
||
| class CreateDecidimMeetingsCalendarFilters < ActiveRecord::Migration[6.1] | ||
| def change | ||
| create_table :decidim_meetings_calendar_filters do |t| |
There was a problem hiding this comment.
I don't like the idea of making this specific to the meetings component.
Sooner or later we will need short URLs somewhere else too.
Could we do something similar to what the shortener gem is doing. We could take inspiration from that. It seems actively developed right now but it's also not super popular, so it may stall at some point (within few years time). So, I'll leave that for your consideration.
There was a problem hiding this comment.
Can you also test if it works with the calendar if the URL is a 301 redirect?
E.g. what happens if you pass the current long link to bit.ly and pass that to the calendar program?
Otherwise we need to take it into account whether the short link should be an alternative render URL or a 301 redirect.
There was a problem hiding this comment.
@alecslupu have you seen this last comment? Do you have any thoughts? Thanks!
There was a problem hiding this comment.
@alecslupu Do you have time to check this issue? We need to get this issue resolved for 0.27, so we can also take over if you are busy.
There was a problem hiding this comment.
@ahukkanen , i already spoke with @andreslucena about this, and I estimate that I will be able to have a try it next week.
There was a problem hiding this comment.
Can you also test if it works with the calendar if the URL is a 301 redirect?
I've tried this along with @carolromero and this works.
We've shortened with bitly a calendar from nightly. It worked well with Google Calendar, Outlook in Office 365 and macOS calendar software. If you want to try it yourselves: https://bit.ly/3l14K8D, there are some meetings at 2022/04/27.
There was a problem hiding this comment.
@alecslupu a friendly reminder about this issue 😄
At the moment, this has a high priority for us, as this is blocking the v0.27.0 release. If you can handle these few days, that'd be great, but if not, don't sweat it, and we'll take this PR over on Monday.
Thanks for your amazing work!!
|
Just a note here that I've started to work on the short links feature, I should be able to open a PR in the following few days. I'll close this one once I get the PR open and mark it will supersede this one. Thanks a lot for the work on this so far @alecslupu ! |
|
Superseded by #9383. |
🎩 What? Why?
Please describe your pull request.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
