Skip to content

Fix Spring errors with Rails 6.1#9032

Merged
andreslucena merged 5 commits intodecidim:developfrom
mainio:fix/spring-with-rails61
Mar 21, 2022
Merged

Fix Spring errors with Rails 6.1#9032
andreslucena merged 5 commits intodecidim:developfrom
mainio:fix/spring-with-rails61

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Mar 17, 2022 •
edited
Loading

🎩 What? Why?

As described at #8411 (comment) and #8610 (comment), Spring gives a bunch of the following kind of errors after the Rails 6.1 upgrade:

** ERROR: directory is already being watched! **

This fixes these errors.

📌 Related Issues

Testing

$ ./bin/spring stop && ./bin/rails c

See that no errors are printed out (also make sure you have Spring enabled).

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@ahukkanen ahukkanen mentioned this pull request Mar 17, 2022
Merged
12 tasks
@ahukkanen ahukkanen requested a review from andreslucena March 18, 2022 12:58
@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Mar 18, 2022

This workaround is from:
rails/spring-watcher-listen#15 (comment)

All credits to them.

andreslucena
andreslucena approved these changes Mar 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I can't reproduce the warning locally, but after reading the spring-watcher-listen's issue, this should work. Also being able to tune this in decidim-core it's a great improvement.

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Mar 21, 2022

For some reason, I can't reproduce the warning locally

Nevermind, it was a problem in my side. I was looking at the wrong terminal, sorry about that 😅

Now I can confirm that this works locally.

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Mar 21, 2022

I'm merging this even. It looks like the github actions/codecov integration has hanged (it's running for 3 days), even though it already finished in their side, so I'd said that's OK to ignore it.

@andreslucena andreslucena merged commit ddda87c into decidim:develop Mar 21, 2022
@ahukkanen ahukkanen deleted the fix/spring-with-rails61 branch April 11, 2022 12:00
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

module: core target: developer-experience

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ahukkanen @andreslucena @alecslupu