Skip to content

Backport "Fix character counter with emoji picker close to maximum characters" to v0.26#9012

Merged
andreslucena merged 1 commit intodecidim:release/0.26-stablefrom
eliegaboriau:release/0.26-stable
Mar 14, 2022
Merged

Backport "Fix character counter with emoji picker close to maximum characters" to v0.26#9012
andreslucena merged 1 commit intodecidim:release/0.26-stablefrom
eliegaboriau:release/0.26-stable

Conversation

@eliegaboriau
Copy link
Copy Markdown
Contributor

@eliegaboriau eliegaboriau commented Mar 14, 2022 •
edited by andreslucena
Loading

🎩 What? Why?

Backports #8916

📌 Related Issues

Testing

  • Write into a textarea until there are less than 4 characters left
  • Notice that the emoji button is disabled
  • Remove characters until there are more than 4 characters left
  • Notice that the emoji button is enabled

♥️ Thank you!

@eliegaboriau eliegaboriau marked this pull request as ready for review March 14, 2022 13:32
@eliegaboriau eliegaboriau mentioned this pull request Mar 14, 2022
Merged
12 tasks
@andreslucena andreslucena changed the title Fix character counter with emoji picker close to maximum characters (… Backport "Fix character counter with emoji picker close to maximum characters" to v0.26 Mar 14, 2022
@andreslucena andreslucena added module: core backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Mar 14, 2022
@andreslucena andreslucena merged commit 082f0a7 into decidim:release/0.26-stable Mar 14, 2022
@eliegaboriau eliegaboriau deleted the release/0.26-stable branch March 14, 2022 14:23
@microstudi microstudi mentioned this pull request Apr 5, 2022
Draft
2 tasks
@microstudi microstudi mentioned this pull request Jul 28, 2022
Closed
@microstudi microstudi mentioned this pull request Aug 26, 2022
Closed
12 tasks
@microstudi microstudi mentioned this pull request Sep 13, 2022
Merged
@alecslupu alecslupu added this to the 0.26.1 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

0.26.1

Development

Successfully merging this pull request may close these issues.

3 participants

@eliegaboriau @andreslucena @alecslupu