Fix flaky spec in elections' key ceremony#8796
Merged
andreslucena merged 4 commits intodevelopfrom Feb 22, 2022
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Lately we've seen a lot of flaky specs with this example in
decidim-elections. This PR fixes that.I think this is for two reasons:
decidim-electionsneeds to interact with an external app,decidim-bulletin-board. For working in CI, this app has theDATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URLthat as its name says, allows specs from decidim-elections to truncate the DB before some specs. This doesn't seems to play nicely with paralell specs from Add parallel_tests for test suite in CI #8678, as on this particular spec that it's a slow one, the DB is changed by the other parallel process (or at least that's my current theory). This seems to fix 100% of cases. I couldn't check this locally asI've rerun this last case 10 times and it's always green:
The tradeoff is that we're losing parallel specs in this case, but I don't see a way of making parallels specs work with the DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL logic. According to the checks that I've seen, we'll go from 22 to 35 minutes of execution on average on this workflow.
📌 Related Issues
Testing
The "[CI] Elections (system public)" is green multiple reruns.
📷 Screenshots
Before this PR:
(6 from the last 13 commits are in red because of the failure of this flaky)