Skip to content

Add reminders for publishing reports to meeting creators#8551

Closed
roxanaopr wants to merge 4 commits intodecidim:developfrom
i-need-another-coffee:feature/add-close-meeting-notifications
Closed

Add reminders for publishing reports to meeting creators#8551
roxanaopr wants to merge 4 commits intodecidim:developfrom
i-need-another-coffee:feature/add-close-meeting-notifications

Conversation

@roxanaopr
Copy link
Copy Markdown
Contributor

As an admin/moderator I want to be able to set up a notification to be sent to meeting organizers if their meeting passed and they didn’t published an event report so that the quality of the meetings on the platform is improved.

It is necessary to have the meeting reports filled in, therefore, email reminders will be sent to event organizers, as an initial notification and a reminder notification.

As an event organizer, I want to receive a notification if my meeting passed and I didn't publish a report so that I can remember to close it and attach the meeting report. Also, I want to receive another reminder at a given time if I still didn't have the chance to close the passed meeting.

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Meta proposal: https://meta.decidim.org/processes/roadmap/f/122/proposals/16852

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@roxanaopr roxanaopr force-pushed the feature/add-close-meeting-notifications branch from fb8f119 to 04afabc Compare November 25, 2021 09:16
@roxanaopr roxanaopr marked this pull request as ready for review November 25, 2021 10:02
@andreslucena andreslucena marked this pull request as draft December 10, 2021 14:31
@andreslucena
Copy link
Copy Markdown
Member

@roxanaopr feel free to change it to "ready for review" when the last comments that we've added in Metadecidim are implemented. Thanks!

@roxanaopr roxanaopr force-pushed the feature/add-close-meeting-notifications branch 3 times, most recently from 4db74a6 to e44e19c Compare December 13, 2021 16:28
@roxanaopr roxanaopr force-pushed the feature/add-close-meeting-notifications branch from e44e19c to 6b3c9f2 Compare December 14, 2021 09:35
@roxanaopr roxanaopr marked this pull request as ready for review December 14, 2021 11:46
show:
administrators: Administrators
allow_public_contact: Allow anyone to send me a direct message, even if I don't follow them.
component_notification_settings:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this key should be moved to decidim-meetings ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is used in decidim-core/app/views/decidim/notifications_settings/show.html.erb and, and in the future, "component_notification_settings" can have multiple values, I think that it will be better to keep it here

@andreslucena
Copy link
Copy Markdown
Member

As we've mentioned in the meeting today, we'll review and merge this after we've seen what's the final form of the ReminderManifest and the rest of the new APIs being developed in #8621 for this same problem with reminders.

@andreslucena andreslucena changed the title Notifications on publish reports to meeting organizers Add reminders for publishing reports to meeting creators Jan 24, 2022
@andreslucena
Copy link
Copy Markdown
Member

As we've mentioned in the meeting today, we'll review and merge this after we've seen what's the final form of the ReminderManifest and the rest of the new APIs being developed in #8621 for this same problem with reminders.

Hi guys! #8621 was merged a couple of minutes ago, we can retackle this one.

@roxanaopr roxanaopr force-pushed the feature/add-close-meeting-notifications branch from 231d7d2 to 68ea333 Compare January 31, 2022 15:32
@andreslucena
Copy link
Copy Markdown
Member

Should we close this one in favor of #8757 @roxanaopr ?

@roxanaopr
Copy link
Copy Markdown
Contributor Author

Should we close this one in favor of #8757 @roxanaopr ?

Sure, thank you!

@roxanaopr roxanaopr closed this Feb 1, 2022
@roxanaopr
Copy link
Copy Markdown
Contributor Author

Closing in favor of #8757

@alecslupu alecslupu deleted the feature/add-close-meeting-notifications branch February 3, 2022 06:32
@alecslupu alecslupu restored the feature/add-close-meeting-notifications branch February 3, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants