Skip to content

Remove etherpad-lite dependency#8541

Merged
andreslucena merged 13 commits intodecidim:developfrom
mainio:refactor/etherpad
Dec 21, 2021
Merged

Remove etherpad-lite dependency#8541
andreslucena merged 13 commits intodecidim:developfrom
mainio:refactor/etherpad

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Nov 23, 2021 •
edited
Loading

🎩 What? Why?

Remove etherpad-lite dependency.

📌 Related Issues

#8516
#7234

Testing

  1. Download etherpad server
  2. Create APIKEY.txt to root directory of etherpad-lite server: echo CHANGE_ME_API_KEY > APIKEY.txt
  3. Run etherpad-lite server: ./src/bin/run.sh
  4. Add etherpad server and api key to .rbenv-vars:
ETHERPAD_SERVER=http://localhost:9001
ETHERPAD_API_KEY=CHANGE_ME_API_KEY
  1. Enable etherpad from development_app/config/initializers/decidim.rb
  2. Run development app: bundle exec rails s
  3. "Enable pads creation" in meetings component settings
  4. Edit meeting so that it has started (but not ended)
  5. Go to meeting's page and you should see etherpad in iframe.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

image

♥️ Thank you!

@lahdeero lahdeero changed the title Replace etherpad-lite dependency Remove etherpad-lite dependency Nov 23, 2021
ahukkanen
ahukkanen reviewed Nov 23, 2021
View reviewed changes
ahukkanen
ahukkanen requested changes Nov 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some API tests.

@andreslucena andreslucena mentioned this pull request Nov 29, 2021
Closed
6 tasks
@ahukkanen
Copy link
Copy Markdown
Contributor

ahukkanen commented Dec 14, 2021

@andreslucena This is ready for review.

andreslucena
andreslucena requested changes Dec 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just the typo catcher 😅
Can you also review the merge conflicts? I didn't check it, but t's probably from the Gemfile.lock. The failing Elections CI specs are unrelated and should be fixed by rebasing against develop

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Dec 20, 2021

Also, I've checked it locally to see if the migration path worked, and it was perfect.

I really appreciated the "Testing" instructions, it has saved me a lot of time. 👏🏽 👏🏽

@andreslucena andreslucena mentioned this pull request Dec 20, 2021
Merged
andreslucena
andreslucena approved these changes Dec 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 👍🏽

@andreslucena andreslucena merged commit 7c15cce into decidim:develop Dec 21, 2021
@andreslucena andreslucena linked an issue Dec 21, 2021 that may be closed by this pull request
Replace libraries (gems) with small communities with alternatives #8516
Closed
6 tasks
@ahukkanen ahukkanen deleted the refactor/etherpad branch December 21, 2021 09:13
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahukkanen ahukkanen ahukkanen requested changes

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

in-review target: developer-experience

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

Replace libraries (gems) with small communities with alternatives

4 participants

@lahdeero @ahukkanen @andreslucena @alecslupu