Skip to content

Fix problems introduced by #8330#8341

Merged
leio10 merged 2 commits intodevelopfrom
fix/8330-fixes
Sep 17, 2021
Merged

Fix problems introduced by #8330#8341
leio10 merged 2 commits intodevelopfrom
fix/8330-fixes

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented Sep 17, 2021

🎩 What? Why?

During the backport of #8330 we discovered some small issues that where fixed on that backport PR. This PR adds those to the develop branch.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@leio10 leio10 changed the title Fix problems instroduced by #8330 Fix problems introduced by #8330 Sep 17, 2021
@leio10 leio10 merged commit 33533a7 into develop Sep 17, 2021
@leio10 leio10 deleted the fix/8330-fixes branch September 17, 2021 13:07
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience type: fix PRs that implement a fix for a bug labels Jan 10, 2022
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants