Webpacker: Do not override the application's package.json#8094
Merged
leio10 merged 5 commits intodecidim:developfrom Jun 8, 2021
Merged
Webpacker: Do not override the application's package.json#8094leio10 merged 5 commits intodecidim:developfrom
leio10 merged 5 commits intodecidim:developfrom
Conversation
12 tasks
7ca9ea2 to
8709e06
Compare
d223c39 to
c7ae786
Compare
leio10
approved these changes
Jun 8, 2021
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Follow up for #8066 (see the related discussion in that issue).
This proposes a solution for the
package.jsonoverride in the webpacker installation task (decidim:webpacker:install).This is not ideal because it is very slow as it clones the whole Decidim git repository to
node_modules.This is, however, how it should be solved. What needs to be done after:
package.jsondevDependenciescorrectly to that file as all the dependencies are now listed withindependencies. ThedevDependenciesare those NPM packages that are not necessarily relevant for the Decidim application (jest related, etc. see Configure webpacker additional paths and entry points programmatically #8066 (comment))@decidim/essentialssystem! "npm i decidim/decidim#develop"withsystem! "npm i @decidim/essentials"📌 Related Issues
Testing
Run the development app with the webpack-dev-server.
📋 Checklist
docs/.