Make collection of initiatives exportable#8033
Merged
leio10 merged 2 commits intodecidim:developfrom Jun 11, 2021
armandfardeau:feature/selective-exports
Merged
Make collection of initiatives exportable#8033leio10 merged 2 commits intodecidim:developfrom armandfardeau:feature/selective-exports
leio10 merged 2 commits intodecidim:developfrom
armandfardeau:feature/selective-exports
Conversation
Contributor
Author
|
@leio10 not sure how to test more on this, if you have any insights feel free |
Contributor
Author
|
Hi @leio10 , Could you review this P.R. please? I would like some insights on the code coverage. |
leio10
approved these changes
Jun 11, 2021
Contributor
leio10
left a comment
There was a problem hiding this comment.
Good job @armandfardeau! Don't worry about the patch coverage, as all the changed files are well covered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When clicking on the export buttons of the initiatives it takes 1h30 to receive it by mail.
The task takes time because it processes all initiatives and associated votes.
Also, all initiatives where queried without the constraint of an organization which is problematic.
📌 Related Issues
Link your PR to an issue
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots