Skip to content

Make collection of initiatives exportable#8033

Merged
leio10 merged 2 commits intodecidim:developfrom
armandfardeau:feature/selective-exports
Jun 11, 2021
Merged

Make collection of initiatives exportable#8033
leio10 merged 2 commits intodecidim:developfrom
armandfardeau:feature/selective-exports

Conversation

@armandfardeau
Copy link
Copy Markdown
Contributor

@armandfardeau armandfardeau commented May 21, 2021

🎩 What? Why?

When clicking on the export buttons of the initiatives it takes 1h30 to receive it by mail.
The task takes time because it processes all initiatives and associated votes.

Also, all initiatives where queried without the constraint of an organization which is problematic.

📌 Related Issues

Link your PR to an issue

Testing

  • Filter initiatives view, then click on export selection
  • Go to your mail, you have only filtered items in file

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Capture d’écran 2021-05-21 à 14 59 34

Capture d’écran 2021-05-21 à 15 00 01

♥️ Thank you!

@armandfardeau armandfardeau marked this pull request as ready for review May 21, 2021 13:37
@armandfardeau
Copy link
Copy Markdown
Contributor Author

armandfardeau commented May 24, 2021

@leio10 not sure how to test more on this, if you have any insights feel free

@armandfardeau
Copy link
Copy Markdown
Contributor Author

Hi @leio10 , Could you review this P.R. please? I would like some insights on the code coverage.

Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @armandfardeau! Don't worry about the patch coverage, as all the changed files are well covered

@leio10 leio10 merged commit 4d97b31 into decidim:develop Jun 11, 2021
@armandfardeau armandfardeau deleted the feature/selective-exports branch June 11, 2021 17:27
@leio10 leio10 mentioned this pull request Jun 14, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants