Skip to content

Do not crash if mandatory fields are blank and registrations are enabled#7636

Merged
mrcasals merged 1 commit intodecidim:release/0.24-stablefrom
CodiTramuntana:backport-0.24/fix/enabled_registrations_mandatory_fields
Mar 18, 2021
Merged

Do not crash if mandatory fields are blank and registrations are enabled#7636
mrcasals merged 1 commit intodecidim:release/0.24-stablefrom
CodiTramuntana:backport-0.24/fix/enabled_registrations_mandatory_fields

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Mar 18, 2021

🎩 What? Why?

Please describe your pull request.
Backport #7634 to release/0.24-stable.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@mrcasals mrcasals changed the title Backport "Do not crash if mandatory fields are blank and registrations are enabled" to 0.24 Do not crash if mandatory fields are blank and registrations are enabled Mar 18, 2021
@mrcasals mrcasals added backport Pull Requests that are a backport for a fixed bug module: meetings type: fix PRs that implement a fix for a bug labels Mar 18, 2021
@mrcasals mrcasals merged commit 55f13a0 into decidim:release/0.24-stable Mar 18, 2021
@tramuntanal tramuntanal deleted the backport-0.24/fix/enabled_registrations_mandatory_fields branch March 18, 2021 11:41
@tramuntanal
Copy link
Copy Markdown
Contributor Author

tramuntanal commented Mar 18, 2021 •
edited
Loading

Hi @mrcasals is there a new policy for backport PR names?
I'm asking just to set the correct title when creating backports

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Mar 18, 2021

Hi! When merging, I try to keep the PR names as clean as possible, to match what should appear in the changelog (thanks to #7461 and related PRs).

It's fine if you open the PR as Backport "..." to 0.XX, but I'll try to keep the PR title as clean as possible when merging. Same with the PR labels!

This was referenced Mar 22, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Pull Requests that are a backport for a fixed bug module: meetings type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tramuntanal @mrcasals