Skip to content

Add notification setting: emails on moderations#7328

Merged
mrcasals merged 2 commits intodecidim:developfrom
mainio:feature/email_on_moderations_toggle
Feb 10, 2021
Merged

Add notification setting: emails on moderations#7328
mrcasals merged 2 commits intodecidim:developfrom
mainio:feature/email_on_moderations_toggle

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Feb 9, 2021

🎩 What? Why?

Currently admins (or moderators) doesn't have chance to opt out from the "A resource has been reported" emails. This pull request adds option for the user to disable moderation emails to him/her.

📌 Related Issues

https://meta.decidim.org/processes/roadmap/f/122/proposals/14324

Testing

  1. Login as admin/moderator
  2. My account -> Notifications settings -> uncheck "I want to receive an email every time something is reported for moderation."
  3. Report something (proposal's comment for example)
  4. Check mail

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

email_on_moderations

♥️ Thank you!

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Feb 9, 2021

OMG yes please thank you 🥺

mrcasals
mrcasals previously approved these changes Feb 9, 2021
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Feb 9, 2021

@decidim/product do you need to check the texts?

@carolromero
Copy link
Copy Markdown
Member

@mrcasals texts are fine, thank you!

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @lahdeero!

@mrcasals mrcasals merged commit 210f743 into decidim:develop Feb 10, 2021
@ahukkanen ahukkanen deleted the feature/email_on_moderations_toggle branch February 12, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants