Skip to content

Fix line breaks in external links#7280

Merged
mrcasals merged 1 commit intodevelopfrom
fix/linebrak_in_external_link
Feb 5, 2021
Merged

Fix line breaks in external links#7280
mrcasals merged 1 commit intodevelopfrom
fix/linebrak_in_external_link

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

If you use the WYSWYG editor with links it breaks with the external links.

Testing

  1. As an admin edit a Process
  2. Add a description with links in a paragraph or in a long list
  3. Go to the frontend
  4. See that the line breaks are broken:
    4.1. In lists, the bullet is not well ordered (it's at the bottom, should be at the top)
    4.2. In paragraphs with links in the middle there's a line break, it shouldn't be.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Backend

image

Before

image

After

image

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrcasals mrcasals merged commit 71e3ccd into develop Feb 5, 2021
@mrcasals mrcasals deleted the fix/linebrak_in_external_link branch February 5, 2021 10:10
@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants