Skip to content

Add default help texts for votings#7174

Merged
mrcasals merged 55 commits intodevelopfrom
feat/add-votings-help-section
Jan 26, 2021
Merged

Add default help texts for votings#7174
mrcasals merged 55 commits intodevelopfrom
feat/add-votings-help-section

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Jan 19, 2021 •
edited by agustibr
Loading

🎩 What? Why?

Adds the default help text for the Votings space.

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

image

♥️ Thank you!

agustibr and others added 30 commits January 18, 2021 16:45
@agustibr
feat(elections): admin create voting spaces
579b4ac
@orlera
feat: make votings publicable (#7152)
8f44865
@agustibr
fix(votings): add pagination to admin index
76c39d5
@agustibr
feat(votings): add admin_logs
2421b3f
@agustibr
feat(votings): add factory and specs for create command, form, model,…
0600cb4 
… admin_log presenter and organization votings query
@agustibr
feat(votings): add votings component controllers/concerns
7912b88
@agustibr
feat(votings): add presenter and permissions specs
6037e3b
@agustibr
chore(votings): update graphQL
26f5107
@agustibr
fix(admin): menu helper spec
402fb64
@agustibr
fix? graphql include context
efbbce4
@agustibr
chore(votings): searchable fields
b8e950a
@agustibr
feat(votings): add seeds
ce4d12b
chore(votings): remove unused files
1b65c2f
test(votings): add system tests
78155ca
feat(votings): add banner & introductionary image
35debdf
chore(votings): remove yet unused files to increase test coverage
bb9ad4d
chore(votings): remove yet unused file
766db88
fix(votings): typo
4c57c63
fix(voting): i18n config
beaf8ae
feat: update a voting
3bd1bee
feat: use slug instead of id in URL
c97342c
feat: publsh-unpublish voting
8988c38
feat: add action buttons
91d5d1f
style: trailing spaces
7d03a64
style: linting
91c87c1
fix: locales
fea6191
feat: public index - p1
0cae966
fix: fitlering & sorting
2194a49
feat: add stripped down show page
4f465d9
feat: badge
0c62eb3
@orlera orlera force-pushed the feat/add-votings-help-section branch from f366790 to 6fe7088 Compare January 20, 2021 10:23
@orlera orlera linked an issue Jan 20, 2021 that may be closed by this pull request
Change the help section for votings #7101
Closed
4 tasks
@orlera orlera self-assigned this Jan 20, 2021
@orlera orlera added project: e-voting Barcelona City Council contract space: votings labels Jan 20, 2021
beagleknight
beagleknight previously approved these changes Jan 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

leio10
leio10 previously approved these changes Jan 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

slickepinne
slickepinne previously approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice description!

Base automatically changed from feat/manage-votings to develop January 25, 2021 13:29
@mrcasals mrcasals dismissed stale reviews from slickepinne, leio10, and beagleknight January 25, 2021 13:29

The base branch was changed.

@orlera orlera mentioned this pull request Jan 26, 2021
Merged
12 tasks
@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Jan 26, 2021

@decidim/mantainers this was approved by product and can be reviewed 🚀

@orlera orlera marked this pull request as ready for review January 26, 2021 13:21
@mrcasals mrcasals merged commit d6d5fa8 into develop Jan 26, 2021
@mrcasals mrcasals deleted the feat/add-votings-help-section branch January 26, 2021 13:48
@mrcasals mrcasals changed the title Change the help section for votings Add default help texts for votings Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agustibr agustibr Awaiting requested review from agustibr

4 more reviewers

@mrcasals mrcasals mrcasals approved these changes

@beagleknight beagleknight beagleknight left review comments

@leio10 leio10 leio10 left review comments

@slickepinne slickepinne slickepinne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@orlera orlera

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change the help section for votings

6 participants

@orlera @beagleknight @leio10 @mrcasals @slickepinne @agustibr