Skip to content

See a deprecation callout in Consultations#7095

Merged
mrcasals merged 4 commits intodevelopfrom
feat/consultations-deprecation
Jan 13, 2021
Merged

See a deprecation callout in Consultations#7095
mrcasals merged 4 commits intodevelopfrom
feat/consultations-deprecation

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Jan 13, 2021 •
edited by agustibr
Loading

🎩 What? Why?

As Consultations will soon be replaced by Votings, a deprecation warning is shown to the admins when they access a Consultation from the admin panel

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

deprecation

♥️ Thank you!

@orlera orlera changed the title Consultations deprecation warning See a deprecation callout in Consultations Jan 13, 2021
@orlera orlera marked this pull request as ready for review January 13, 2021 09:05
@github-actions github-actions bot mentioned this pull request Jan 13, 2021
Closed
@leio10 leio10 added the project: e-voting Barcelona City Council contract label Jan 13, 2021
@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Jan 13, 2021

Review app: https://decidim-staging-pr-257.herokuapp.com/

agustibr
agustibr approved these changes Jan 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

leio10
leio10 approved these changes Jan 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👍

@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Jan 13, 2021

@decidim/product could you please review this PR? :)
Here's the review app

slickepinne
slickepinne approved these changes Jan 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🎉

@carolromero
Copy link
Copy Markdown
Member

carolromero commented Jan 13, 2021

Good job @orlera! 👏 👏

@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Jan 13, 2021

@decidim/core approved by product ✅ Could you review this please? :)

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Jan 13, 2021

Looks good! Thanks!

@mrcasals mrcasals merged commit a453ffc into develop Jan 13, 2021
@mrcasals mrcasals deleted the feat/consultations-deprecation branch January 13, 2021 12:47
@andreslucena andreslucena mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beagleknight beagleknight Awaiting requested review from beagleknight

4 more reviewers

@agustibr agustibr agustibr approved these changes

@leio10 leio10 leio10 approved these changes

@mrcasals mrcasals mrcasals approved these changes

@slickepinne slickepinne slickepinne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: consultations project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

See a deprecation callout in Consultations

6 participants

@orlera @carolromero @mrcasals @agustibr @leio10 @slickepinne