Fix avoid removing tag style on custom sanitize#7018
Merged
Conversation
12 tasks
mrcasals
reviewed
Dec 15, 2020
mrcasals
approved these changes
Dec 15, 2020
| expect(helper.decidim_sanitize(user_input)).to include("<p>") | ||
| expect(helper.decidim_sanitize(user_input)).to include("</p>") | ||
| expect(helper.decidim_sanitize(user_input)).to eq(user_input) | ||
| expect(helper.decidim_sanitize_newsletter(user_input)).to include("<p>") |
Contributor
There was a problem hiding this comment.
These tests are a little weird because they're testing two different methods, I think it's probably better to have different specs! 😄
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The preview mailer continues showing some styles rules due to something is removing style tag.
In PR #6876 there was an adapter that avoid that in the premailer process. But also, there was a custom sanitize process on the image_text_cta cell that removes it. With this PR I widen the rules adding style tag to avoid the deletion.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing

Before
After
