Skip to content

Fix linebreaks in WYSWYG editor#6996

Merged
ivan-mr merged 43 commits intodecidim:developfrom
mainio:feature/editor-linebreak
Dec 20, 2020
Merged

Fix linebreaks in WYSWYG editor#6996
ivan-mr merged 43 commits intodecidim:developfrom
mainio:feature/editor-linebreak

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Dec 7, 2020

🎩 What? Why?

Common content management need is that user can make single line breaks into text. Currently in Decidim it's impossible to make line breaks, paragraph spacing comes after each press of the enter. For example, admin wants to add contact details into contact information page like this:

John Doe
john.doe@foo.bar
12345678


Joanna Doe
joanna.doe@foo.bar
987654321

This is more practical to do using line breaks / br tags and this module (pull request) adds line break / br tag feature to quill (editor). Works with shift+enter or clicking the icon in the toolbar.

📌 Related Issues

#2000
slab/quill#1187
slab/quill#252

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

♥️ Thank you!

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11974 lines exceeds the maximum allowed for the inline comments feature.

@andreslucena andreslucena changed the title Feature/editor linebreak Fix linebreaks in WYSWYG editor Dec 15, 2020
@ivan-mr ivan-mr self-assigned this Dec 15, 2020
@ivan-mr ivan-mr self-requested a review December 15, 2020 21:36
Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lahdeero ! Everything seems ok, but first of all you have to rebase your branch due to some conflicts.

@lahdeero lahdeero force-pushed the feature/editor-linebreak branch from 53cc810 to 7e9ad54 Compare December 17, 2020 11:40
@lahdeero
Copy link
Copy Markdown
Contributor Author

@ivan-mr Done.

Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @lahdeero .

@ivan-mr ivan-mr merged commit c978b2f into decidim:develop Dec 20, 2020
@ahukkanen ahukkanen deleted the feature/editor-linebreak branch December 21, 2020 15:22
@mrcasals mrcasals added the type: fix PRs that implement a fix for a bug label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants