Fix linebreaks in WYSWYG editor#6996
Merged
ivan-mr merged 43 commits intodecidim:developfrom Dec 20, 2020
Merged
Conversation
- Fixed bug where backspace deleted text twice - Fixed bug where backspace didnt delete two invisible characters at once - Added test
53cc810 to
7e9ad54
Compare
Contributor
Author
|
@ivan-mr Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Common content management need is that user can make single line breaks into text. Currently in Decidim it's impossible to make line breaks, paragraph spacing comes after each press of the enter. For example, admin wants to add contact details into contact information page like this:
This is more practical to do using line breaks / br tags and this module (pull request) adds line break / br tag feature to quill (editor). Works with shift+enter or clicking the icon in the toolbar.
📌 Related Issues
#2000
slab/quill#1187
slab/quill#252
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing