Skip to content

Backport "Fix broken dashboard action logs under certain conditions" to 0.23#6930

Merged
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
mainio:backport/6857
Nov 25, 2020
Merged

Backport "Fix broken dashboard action logs under certain conditions" to 0.23#6930
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
mainio:backport/6857

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Nov 25, 2020 •
edited
Loading

🎩 What? Why?

Backports the fix from #6857 to 0.23.

📌 Related Issues

Testing

See original issue.

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@ahukkanen
Fix broken dashboard action logs under certain conditions (decidim#6857)
2686799 
* Fix broken dashboard action logs and add specs

* Avoid autoload conflicts with the admin log presenter tests

Before the autoloader could confuse the admin log presenters
with the normal presenters. This is an attempt to try to avoid
this issue.

* Clarify the admin log presenter shared example context name

* Fix invalid namespace with meetings admin log spec

* Change the namespacing convention in the specs

* Fix return type comment
@tramuntanal
Copy link
Copy Markdown
Contributor

tramuntanal commented Nov 25, 2020

Merging as erb-lint error has nothing to do with this PR

@tramuntanal tramuntanal merged commit 8ca570a into decidim:release/0.23-stable Nov 25, 2020
@ahukkanen ahukkanen deleted the backport/6857 branch November 25, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tramuntanal tramuntanal tramuntanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahukkanen @tramuntanal