Skip to content

Backport "Fix traceability logs with invalid record" to 0.23#6928

Merged
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
mainio:backport/6879
Nov 25, 2020
Merged

Backport "Fix traceability logs with invalid record" to 0.23#6928
tramuntanal merged 1 commit intodecidim:release/0.23-stablefrom
mainio:backport/6879

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Nov 25, 2020 •
edited
Loading

🎩 What? Why?

Backports the fix from #6879 to 0.23.

📌 Related Issues

Testing

See the original issue.

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@ahukkanen
Fix traceability logs with invalid record (decidim#6879)
faf35ed 
* Prevent traceability action log for invalid records

* Add test for creating invalid records with traceability

* Add a spec testing creating assembly with too large image dimensions

* Add a spec testing updating assembly with too large image dimensions

* Add a test image with large image dimensions to fail uploader checks

* Enable checking the hero image error message for the create spec
@tramuntanal tramuntanal self-assigned this Nov 25, 2020
@tramuntanal tramuntanal merged commit a39c7ae into decidim:release/0.23-stable Nov 25, 2020
@ahukkanen ahukkanen deleted the backport/6879 branch November 25, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tramuntanal tramuntanal tramuntanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tramuntanal tramuntanal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahukkanen @tramuntanal