Skip to content

Export election results#6846

Merged
tramuntanal merged 10 commits intodevelopfrom
feature/export-elections
Nov 24, 2020
Merged

Export election results#6846
tramuntanal merged 10 commits intodevelopfrom
feature/export-elections

Conversation

@slickepinne
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne commented Nov 11, 2020

🎩 What? Why?

This PR adds the export of election results through the open data link in the footer.

📌 Related Issues

Testing

Click the link in the footer to generate the data and download the file afterward. The results will be inside the open-data-elections.csv file.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@slickepinne slickepinne self-assigned this Nov 11, 2020
@slickepinne slickepinne changed the base branch from develop to feature/show-elections-results November 11, 2020 12:17
beagleknight
beagleknight previously approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

leio10
leio10 previously approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@slickepinne slickepinne force-pushed the feature/show-elections-results branch from 40c218d to c98ae68 Compare November 16, 2020 10:17
@slickepinne slickepinne force-pushed the feature/export-elections branch 2 times, most recently from a8267af to 3e7d553 Compare November 16, 2020 15:01
@slickepinne
Copy link
Copy Markdown
Contributor Author

slickepinne commented Nov 16, 2020 •
edited
Loading

Hello @decidim/core, this can get reviewed. 😊 One issue I found is that I’m not sure if the OpenDataJob task works correctly. Previous generated open data files don’t get overwritten although they should.

agustibr
agustibr previously approved these changes Nov 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Good work!!

@Leusev Leusev self-requested a review November 18, 2020 08:15
@slickepinne slickepinne force-pushed the feature/show-elections-results branch from a58953a to 58da3db Compare November 19, 2020 09:50
@slickepinne slickepinne force-pushed the feature/export-elections branch from 3e7d553 to 43f3e03 Compare November 19, 2020 10:24
Base automatically changed from feature/show-elections-results to develop November 20, 2020 07:34
@tramuntanal tramuntanal dismissed stale reviews from agustibr, leio10, and beagleknight November 20, 2020 07:34

The base branch was changed.

@tramuntanal
Copy link
Copy Markdown
Contributor

tramuntanal commented Nov 20, 2020

Conflicts arised @slickepinne , can you check please?

@slickepinne slickepinne force-pushed the feature/export-elections branch from 43f3e03 to 2eb3983 Compare November 20, 2020 08:17
@slickepinne
Copy link
Copy Markdown
Contributor Author

slickepinne commented Nov 20, 2020

Hi @tramuntanal, the conflicts are gone. 😊

@tramuntanal tramuntanal self-assigned this Nov 24, 2020
tramuntanal
tramuntanal approved these changes Nov 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@tramuntanal tramuntanal merged commit 26f4198 into develop Nov 24, 2020
@tramuntanal tramuntanal deleted the feature/export-elections branch November 24, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leusev Leusev Awaiting requested review from Leusev

4 more reviewers

@tramuntanal tramuntanal tramuntanal approved these changes

@beagleknight beagleknight beagleknight left review comments

@agustibr agustibr agustibr left review comments

@leio10 leio10 leio10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tramuntanal tramuntanal

@slickepinne slickepinne

Labels

in-review module: core module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Download results of an Election on an open format (Open Data)

7 participants

@slickepinne @tramuntanal @beagleknight @agustibr @leio10 @mrcasals @Leusev