Add caching to proposals#6808
Merged
mrcasals merged 5 commits intodecidim:developfrom Jan 13, 2021
armandfardeau:feature/proposals-caching
Merged
Add caching to proposals#6808mrcasals merged 5 commits intodecidim:developfrom armandfardeau:feature/proposals-caching
mrcasals merged 5 commits intodecidim:developfrom
armandfardeau:feature/proposals-caching
Conversation
Contributor
Author
|
@andreslucena Hello, what do you think about it? I would like to have your insights on this. |
tramuntanal
previously requested changes
Dec 15, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
Thanks for the proposal @armandfardeau !
Remember to take the locale into account
Contributor
|
Thanks, @armandfardeau! Merging!! |
This was referenced Mar 3, 2021
This was referenced Mar 8, 2021
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We notice a lack of performance on the proposals index,
The first one is the filters, which are complex and generate a lot of rendering, and can be cached until the filter attributes change.
The second one is proposal cards, due to random seed ordering, it cannot be cached as a collection.
Therefore all proposals must be cached individually and rendered as a collection of cached objects.
The proposal card is complex and depends on many elements, (followers, votes, a user connected, etc...)
This pull request is a proposition of implementation, feel free to discuss it.
Performance overall