Skip to content

Fix highlighted participatory processes title#6798

Merged
tramuntanal merged 1 commit intodevelopfrom
fix/highilghted_processes_title
Nov 4, 2020
Merged

Fix highlighted participatory processes title#6798
tramuntanal merged 1 commit intodevelopfrom
fix/highilghted_processes_title

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Nov 4, 2020

🎩 What? Why?

Please describe your pull request.
Highlighted participatory processes who's title contain chars that are html escaped, render the chars double escaped thus producing D'Artagnan instead of D'Artagnan.

This PR fixes this situation.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.
Create a ParticipatoryProcess with a title that contains some of the symbols in: <, ', &. Mark it as promoted and go to /processes to check that its title is correctly rendered.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Before
image

After
image

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me @tramuntanal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants