Detect the use of spam-bots and ban non compliant users (part 1) by roxanaopr · Pull Request #6696 · decidim/decidim

roxanaopr · 2020-10-16T09:34:20Z

🎩 What? Why?

Implement a way to report users

Like we have a way to flag a contribution for moderation, a similar mechanism can be implemented to flag users and give moderators the ability to block said user. Everyone can participate in this reporting (admin, moderators, users) and flag users based on their harmful behaviour towards the debate or the content they posted on they public profile (avatar, biography, personal website).

Add a flag to report users on their public profile;
In the admin, add a column to the participant table that displays the number of time a user was reported and make a sortable column so the admin can see first the ones with most reports and take action (block) if needed;
Send notification to moderator and admin when a user is reported.

📌 Related Issues

Meta Decidim: https://meta.decidim.org/processes/roadmap/f/122/proposals/15628

Testing

Open the website, browse the homepage for an event that has an username
Navigate the username profile page, and observe the flag button
Click Report (flag icon near nickname), and fill in the data (or login and retry)
Navigate to admin Interface in "Participants" -> "Reported Users"
Observe the user details (username, reason, justification)
Visiting the Participants section, the report count column should be sortable, and shoud display 1 in the corresponding user row
Click the unreport functionality, and observe what is happening
8 Navigate to Participants section, and now the report count should indicate 0

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

📷 Screenshots

Please add screenshots of the changes you're proposing

♥️ Thank you!

Bump develop to next release version

alecslupu · 2020-10-16T12:12:33Z

The failing test is the flacky one related to maps.
@decidim/core, can you retry that specific job ?

tramuntanal · 2020-11-03T08:27:42Z

Welcome @roxanaopr on what I think is your first PR!
I've re-run the test @alecslupu
@decidim/product I see in meta-decidim that it has been approved, but can you confirm this partial implementation of the feature?

roxanaopr · 2020-11-03T08:48:16Z

Welcome @roxanaopr on what I think is your first PR!
I've re-run the test @alecslupu
@decidim/product I see in meta-decidim that it has been approved, but can you confirm this partial implementation of the feature?

Hi @tramuntanal! This pull request is only for part 1 (Implement a way to report users) of the meta-decidim request. For the rest of it we have/will have other PRs

…-report-user-functionality

…emend-cofe/decidim into feature/add-report-user-functionality

tramuntanal · 2020-11-04T07:36:44Z

ok, thanks for the feedback @roxanaopr , waiting for @decidim/product 's feedback

carolromero · 2020-11-04T13:02:29Z

Hi there! I confirm this is approved by @decidim/product. One detail, could we place the icons so that they are not so tight? Something like that?

Thanks!

…-report-user-functionality

alecslupu · 2020-11-04T15:09:26Z

@carolromero the change requested has been implemented ...

carolromero · 2020-11-06T08:19:45Z

Thanks, @alecslupu!

tramuntanal

Good job @roxanaopr!
I've just found some commented code to be removed 😄
Also I'm not sure if decidim-core/app/cells/decidim/author/flag_user.erb should directly render decidim/shared/flag_user_modal (because the flag_user may be rendered more than once in the same screen) but for consistency we should encapsulate it into a author_cell#flag_user_modal method, don't you think? 🤔

decidim-admin/app/controllers/decidim/admin/moderated_users_controller.rb

decidim-admin/config/routes.rb

decidim-admin/app/views/decidim/admin/moderated_users/index.html.erb

decidim-core/lib/decidim/user_reportable.rb

tramuntanal · 2020-11-11T07:38:00Z

decidim-core/app/views/decidim/profiles/show.html.erb

+<%=
+  render partial: "decidim/shared/flag_user_modal", locals: {
+      reportable: profile_holder,
+      form: report_form,
+      url: decidim.report_user_path(sgid: profile_holder.to_sgid.to_s)
+  }


Shouldn't this be rendered by decidim-core/app/cells/decidim/author/flag_user.erb?

The tricky part is that report_form, that is being initialized in the controller part.

tramuntanal · 2020-11-11T07:38:10Z

decidim-core/app/views/decidim/user_activities/index.html.erb

+<%=
+  render partial: "decidim/shared/flag_user_modal", locals: {
+      reportable: user,
+      form: report_form,
+      url: decidim.report_user_path(sgid: user.to_sgid.to_s)
+  }


Shouldn't this be rendered by decidim-core/app/cells/decidim/author/flag_user.erb?

The tricky part is that report_form, that is being initialized in the controller part.

tramuntanal · 2020-11-11T07:38:17Z

decidim-core/app/views/decidim/user_timeline/index.html.erb

+<%=
+  render partial: "decidim/shared/flag_user_modal", locals: {
+      reportable: user,
+      form: report_form,
+      url: decidim.report_user_path(sgid: user.to_sgid.to_s)
+  }


Shouldn't this be rendered by decidim-core/app/cells/decidim/author/flag_user.erb?

The tricky part is that report_form, that is being initialized in the controller part.

We pass it as a parameter, no?

tramuntanal

Thanks for the refactor @alecslupu @roxanaopr

alecslupu and others added 11 commits October 13, 2020 10:12

Merge pull request #7 from decidim/develop

09968d4

Bump develop to next release version

Merge branch 'develop' of github.com:decidim/decidim into develop

9fde202

Adding functionality to report users

5ce30cd

Adding admin log for unreport, i18n string fixes

33719c2

Running linters

f4c6553

Normalize locales

a23bc4b

Adding UserGroup Compatibility, Adding Tests

5c0fee3

Adding tests for reported user functionality

04936c3

Running linters

b4fd2dd

Fixing failing test, Running linters

1ff4fb6

Update "send notification" method and rename report column from admin.

b26292e

roxanaopr marked this pull request as draft October 16, 2020 09:34

roxanaopr added 2 commits October 16, 2020 12:37

Add PR number to Change Log.

64ff58e

Fix linting errors from .md file.

583fb61

roxanaopr marked this pull request as ready for review October 16, 2020 11:47

alecslupu added 3 commits October 19, 2020 10:55

Merge branch 'develop' of github.com:decidim/decidim into develop

0cffe2c

Merge branch 'develop' of github.com:decidim/decidim into develop

f9f5580

Merge branch 'develop' of github.com:decidim/decidim into develop

2c3c667

alecslupu mentioned this pull request Oct 26, 2020

wip: Detect the use of spam-bots and ban non compliant users (part 1) #6656

Closed

12 tasks

alecslupu added 2 commits October 29, 2020 01:29

Merge branch 'develop' of github.com:decidim/decidim into develop

cdb057e

Merge branch 'develop' of github.com:decidim/decidim into develop

bb451bb

alecslupu added 5 commits November 3, 2020 21:19

Merge branch 'develop' of github.com:decidim/decidim into feature/add…

9501d44

…-report-user-functionality

Merge branch 'feature/add-report-user-functionality' of github.com:tr…

96070dc

…emend-cofe/decidim into feature/add-report-user-functionality

Fixing Linter issues

5a17dd0

Merge branch 'develop' of github.com:decidim/decidim into develop

54d8b3d

Merge branch 'develop' into feature/add-report-user-functionality

ba31e5f

alecslupu added 2 commits November 4, 2020 17:07

Adding space formatting for report button in profile section

d69b3ce

Merge branch 'develop' of github.com:decidim/decidim into feature/add…

a99ddee

…-report-user-functionality

This was referenced Nov 4, 2020

Detect the use of spam-bots and ban non compliant users (part 2) i-need-another-coffee/decidim#8

Closed

Detect the use of spam-bots and ban non compliant users (part 2) #6804

Merged

tramuntanal added the in-review label Nov 10, 2020

tramuntanal self-assigned this Nov 10, 2020

tramuntanal suggested changes Nov 11, 2020

View reviewed changes

roxanaopr and others added 2 commits November 11, 2020 10:12

Remove commented code and do minor adjustments

6cfd96a

Applying changes related to report form suggested by reviewers

075bff2

alecslupu force-pushed the feature/add-report-user-functionality branch from 9621427 to 075bff2 Compare November 12, 2020 22:58

tramuntanal approved these changes Nov 13, 2020

View reviewed changes

tramuntanal merged commit 544c3b2 into decidim:develop Nov 13, 2020

mrcasals added module: admin module: core type: feature labels Feb 26, 2021

ahukkanen mentioned this pull request Jun 14, 2021

Fix user report notification reported user name #8130

Merged

12 tasks

carlobeltrame mentioned this pull request Feb 1, 2022

Bot Registration vermeiden stadtluzern/decidim-ocl#183

Closed

Uh oh!

Conversation

roxanaopr commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📋 Checklist

📷 Screenshots

Uh oh!

alecslupu commented Oct 16, 2020

Uh oh!

tramuntanal commented Nov 3, 2020

Uh oh!

roxanaopr commented Nov 3, 2020

Uh oh!

tramuntanal commented Nov 4, 2020

Uh oh!

carolromero commented Nov 4, 2020

Uh oh!

alecslupu commented Nov 4, 2020

Uh oh!

carolromero commented Nov 6, 2020

Uh oh!

tramuntanal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tramuntanal Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

alecslupu Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

tramuntanal Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

alecslupu Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

tramuntanal Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

alecslupu Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

tramuntanal Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

tramuntanal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roxanaopr commented Oct 16, 2020 •

edited

Loading