Add missing margin between username and title in cards#6674
Merged
ivan-mr merged 5 commits intodecidim:developfrom Oct 14, 2020
SilviaGrrr:fix/6545
Merged
Add missing margin between username and title in cards#6674ivan-mr merged 5 commits intodecidim:developfrom SilviaGrrr:fix/6545
ivan-mr merged 5 commits intodecidim:developfrom
SilviaGrrr:fix/6545
Conversation
…udes styling conventions required by codeclimate automated test.
ivan-mr
approved these changes
Oct 13, 2020
Contributor
ivan-mr
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @SilviaGrrr !
Before merge I want to wait for @decidim/product
microstudi
approved these changes
Oct 14, 2020
andreslucena
approved these changes
Oct 14, 2020
Member
|
I've changed the title because after it's merged it'll be the commit message and I don't like to add these kinds of metadata (like issue number or [Design]) for being consistent with the history of commits. Just a little nitpicking on my side 😅 |
carolromero
approved these changes
Oct 14, 2020
Member
|
Good job @SilviaGrrr!! 😄 |
Contributor
|
@ivan-mr this is ready to go! thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add missing margin between title and author (proposals) (issue #6545).
📌 Related Issues
Testing
Previous PR request automated tests failed only regarding minor styling issues (codeclimate), which were corrected for the present PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
before:
after:
