Skip to content

Remove unused Initiative author i18n block#6667

Merged
ivan-mr merged 1 commit intodevelopfrom
fix/initiative-author-attributes
Oct 13, 2020
Merged

Remove unused Initiative author i18n block#6667
ivan-mr merged 1 commit intodevelopfrom
fix/initiative-author-attributes

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Please describe your pull request.

There's a block in Initiatives locales that's not being used currently and was there from legacy iterations. This PR removes these unused strings.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

This is actually like a philosophical question: how can I test something that actually don't exist?

One of the searches I made for "testing" that these strings are unused:

$ egrep -ri "(document_id|province|address|post_code)" .|grep -v config/locales 
> ./spec/services/decidim/initiatives/data_encryptor_spec.rb:          postal_code: ::Faker::Address.zip_code }
> ./spec/cells/decidim/initiatives_votes/vote_cell_spec.rb:      postal_code: ::Faker::Address.zip_code
> ./spec/commands/decidim/initiatives/vote_initiative_spec.rb:          postal_code: ::Faker::Address.zip_code

Note that postal_code is unrelated to this block.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @andreslucena!

@ivan-mr ivan-mr merged commit 34436b2 into develop Oct 13, 2020
@ivan-mr ivan-mr deleted the fix/initiative-author-attributes branch October 13, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initiatives talk about "DNI/NIE" and that's only for Spain

3 participants