Skip to content

Fix deprecated js loadMap on meetings index#6654

Merged
ivan-mr merged 3 commits intodevelopfrom
fix/loadMap_on_meetings_search_form
Oct 13, 2020
Merged

Fix deprecated js loadMap on meetings index#6654
ivan-mr merged 3 commits intodevelopfrom
fix/loadMap_on_meetings_search_form

Conversation

@ivan-mr
Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr commented Oct 9, 2020

🎩 What? Why?

Please describe your pull request.
When someone searches the search form from meetings, a js error appears in the console.
This RP removes the stale lines that were generating these errors.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Captura de pantalla de 2020-10-09 18-23-27

@mrcasals
Copy link
Copy Markdown
Contributor

@ivan-mr heads-up, linter is complaining! 😄

@Leusev Leusev self-requested a review October 13, 2020 11:15
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me @ivan-mr 👍

@ivan-mr ivan-mr merged commit 4fcb7c2 into develop Oct 13, 2020
@ivan-mr ivan-mr deleted the fix/loadMap_on_meetings_search_form branch October 13, 2020 11:19
@tramuntanal
Copy link
Copy Markdown
Contributor

@mrcasals it's been merged

@mrcasals mrcasals added module: meetings type: fix PRs that implement a fix for a bug labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: meetings type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants